Repository navigation
chore(deps): bump TanStack Start and Router together - #561
Merged
Merged
Conversation
aicayzer
commented
Oct 21, 2026
aicayzer
left a comment
Contributor
Author
There was a problem hiding this comment.
Review: checks only
aicayzer
marked this pull request as ready for review
October 21, 2026 18:20
aicayzer
enabled auto-merge (squash)
October 21, 2026 18:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves
@tanstack/react-startto 1.169.3 and@tanstack/react-routerto 1.170.45 together, and switches the one server function to the renamed.validator()method. This supersedes #516, which bumped Start alone to 1.168.60: that release depends on Router 1.170.41 exactly while this repository pinned 1.170.40, so two Router copies were installed and the Start type augmentation landed on the wrong one. Every route'sserver:option then failed type-checking (TS2353) andBuild and type-checkfailed.Changes
package.jsonandpnpm-lock.yaml:@tanstack/react-start1.168.59 to 1.169.3,@tanstack/react-router1.170.40 to 1.170.45 (the exact version Start 1.169.3 depends on).@tanstack/react-router-devtoolsis unchanged: it declares Router as a range peer dependency, which 1.170.45 satisfies.src/routes/$.tsx:createServerFn(...).inputValidator(...)becomes.validator(...). Start removed the deprecated.inputValidator()in start-client-core 1.170.36 (it takes the same validator), and the build failed to prerender/overviewwithout this change.Testing
pnpm install, thenpnpm why @tanstack/react-router: one version (1.170.45) installed.pnpm build: passes, 319 pages prerendered.pnpm build:status: passes.pnpm types:check: passes for both targets.pnpm test: 28 files, 366 tests pass.pnpm dev, then fetched/llms.txt,/api/search?query=key,/api/docs/search?q=key,/api/docs/topics,/docs-map.md,/overviewand/overview.md(all 200 with expected content), and atools/listrequest to/mcp(returns the tool list).Notes for reviewers
.inputValidator()removal landed in the start-client-core range it now depends on, so it is a real breaking change for this repository. No other use of it exists insrc/.Checklist