Repository navigation
Conversation
Contributor
Author
|
Carried into #621, because this change and the v0.0.35 sync fail CI without each other. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Views hold a query, a sort and an optional group, and no layouts. This updates the guides, the CLI reference, the devices overview, the API reference and the view catalog description to match withmarfa/marfa#2391. It merges only after that change is released and synced into these docs.
Changes
list-filter-search: "Save a list as a view" showssortandgroupin the CLI, HTTP and TypeScript, and notes that a folder is filtered withedge[in-folder]orsource.list-filter-searchalso says a view's grouping is removed withgroup: nullormarfa views change --group null.read-a-view: removes layouts andsum, drops--layout, and says a working copy answers abackrefcondition where it holds that edge type whole.cli,devices,api-reference/index: word the view commands and the offline reads without layouts.catalog/(system)/view: the description now matches the newsystem.viewtype.Testing
pnpm testwere not run. Expect CI to fail until the Marfa release is synced: the catalog description check and the CLI command check read synced files (view.json,COMMANDS.md) that still describe layouts. Do not runscripts/sync-from-marfa.shfor this change.COMMANDS.md,openapi.jsonandview.json, and searched the content for the removed words.Notes for reviewers
swift-sdk.mdxstill describes layouts onSavedView. It follows the Swift SDK change, which another piece of work makes, so I left it. The Swift lines inread-a-viewassume the SDK drops thelayout:parameter.Checklist