Repository navigation
feat(callouts): draw callouts in the Soft family with a required bold title - #636
Merged
Merged
Conversation
… title Callouts take a tinted panel, a bold title in the tint's dark color and the body under it, with no icon. The colors are the --marfa-callout-* tokens, in light and dark. A content lint rule requires a title on every callout, and each page's callouts now carry one.
aicayzer
commented
Oct 25, 2026
aicayzer
left a comment
aicayzer
left a comment
Contributor
Author
There was a problem hiding this comment.
Review: checks only
Styling change, looked at in the browser by the builder and again by the session; build, type check and tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draws every callout as a soft tinted panel with a bold title and the body under it. There is no border, shadow or icon.
What changes
Callouttakes a requiredtitle. Theiconprop is gone, because nothing passed it.tipandidea), error (red) and success (mint). They are the--marfa-callout-<kind>-bg,-titleand-bodycustom properties insrc/styles/app.css, so other components can use them.<Calloutwith notitle=, and has a test that the rule fires on a bad sample.STYLE.mddescribes the component: title required, no icon,warnfor a loss or something that can't be undone.Checked
pnpm build,pnpm build:status,pnpm types:checkandpnpm testpass. All seven callouts were viewed in light and dark, and/overview.mdwas read.This is a draft until the before and after comparison is approved.