Repository navigation
docs: say that a step's family in tokens.json names a font token - #11
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N8f1sEEDiR2ikgqtHWXgYn
🦋 Changeset detectedLatest commit: 4ae9287 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A reader of
tokens.jsoncouldn't tell that a step'sfamilyis a key, not a font stack. The "In code" section oftypography.mdnow says so.In CSS,
--vlab-type-<step>-familyalready resolves to the stack, asvar(--vlab-font-sans). Only a JSON consumer, such as a server-rendered image, has to look it up.Patch changeset: a text changes.
Evidence
typography.mdsays "readtypein@variablelab/brand/tokens.json" and nothing more.After: it adds that
familynames a font token,sansormono, whose stack is that token'svalueunderfont.pnpm checkexits 0.Merge Danger
Door: two-way.
Blast Radius: none.
One sentence in a chapter; no token, export or asset changes.
🤖 Generated with Claude Code
https://claude.ai/code/session_01N8f1sEEDiR2ikgqtHWXgYn