Repository navigation
fix(examples): apply the 24 h release-age cooldown to the pnpm examples - #58
Merged
Merged
Conversation
The pnpm examples install with --ignore-workspace, which skips pnpm-workspace.yaml and its cooldown. Each one now has an .npmrc with the same minimum release age and the same @variablelab/* and @rrlab/* excludes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012xRhgX9oTNKCAhLoiC8vSX
|
Contributor
Preview releaseLatest commit: No packages have been released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 8 pnpm examples now use the same 24 h release-age cooldown as the repo root. They install with
--ignore-workspace, which skipspnpm-workspace.yaml, so each one gets its own.npmrc:examples/<pnpm example>/ +└── .npmrc # minimum-release-age=1440, excludes @variablelab/* and @rrlab/*The contributing and development docs now tell a new pnpm example to copy it.
Evidence
pnpm config get minimum-release-age --ignore-workspaceprintsundefined), so atypescriptrelease from 9 h ago is accepted.After: it prints
1440, and adding that release fails withERR_PNPM_NO_MATURE_MATCHING_VERSION. An@rrlab/clirelease from 3 h ago, which pulls in@variablelab/*releases just as new, still installs.mise run examples:checkpasses for all 12 examples, and e2e passes for all 8 pnpm examples.Merge Danger
Door: two-way
Blast Radius: examples
A release less than 24 h old can no longer go into a pnpm example. The 4 bun and deno examples are unchanged: bun 1.2.4 has no release-age setting.
🤖 Generated with Claude Code
https://claude.ai/code/session_012xRhgX9oTNKCAhLoiC8vSX