Repository navigation
fix(examples): give each example its own ports - #59
Merged
Merged
Conversation
The root `mise run test:e2e` runs the suites in parallel, and five examples shared a port with another one. The CommonJS twins move to 3011-3013, ssr-react-router to 3005 (its `start` task now listens there too) and ssr-tanstack-start to 3006. The examples README lists every example's ports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012xRhgX9oTNKCAhLoiC8vSX
|
Contributor
Preview releaseLatest commit: No packages have been released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mise run test:e2eruns every suite in parallel, but five examples share a port with another example, so their suites can't run at the same time. They move to ports of their own:backend-node-cjsbackend-bun-cjsbackend-deno-cjsssr-react-router(start, E2E)start3000 or a random port, E2E 3002ssr-tanstack-start(dev,start, E2E)The other seven examples keep their ports. The examples README now lists every example's ports, and the contributing guide asks new examples to pick unused ones.
Evidence
main, 3001, 3002 and 3003 are each used by more than one example's E2E suite.After: no example shares a port.
mise run test:e2eruns all 12 suites in parallel and passes, with no port-in-use errors.examples:checkpasses.ssr-react-router'sstartsets no port, so it listens on 3000, or on a random port when 3000 is busy.After: it prints
[react-router-serve] http://localhost:3005.Merge Danger
Door: two-way
Blast Radius: examples only. Anyone who opens these five examples on their old ports has to use the new ones.
ssr-react-router'sstartnow fails when 3005 is busy instead of taking another port.🤖 Generated with Claude Code
https://claude.ai/code/session_012xRhgX9oTNKCAhLoiC8vSX