Skip to content

ci: type-check .astro files with rr check through @rrlab/astro-plugin - #10

Merged
rqbazan merged 2 commits into
mainfrom
ci/rr-astro-plugin
Oct 18, 2026
Merged

rqbazan merged 2 commits into
mainfrom
ci/rr-astro-plugin

Conversation

@rqbazan

@rqbazan rqbazan commented Oct 18, 2026

Copy link
Copy Markdown
Member

Summary

rr check now type-checks .astro files through @rrlab/astro-plugin 0.1.0, which runs astro check for rr's type check. CI runs one step in place of two.

 # run-run.config.mts
-  plugins: [biome()],
+  plugins: [biome(), astro()],

 # .github/workflows/ci.yml
-  🧹 Lint and format   pnpm rr jsc
-  🔍 Check types       pnpm astro check
+  🔍 Check             pnpm rr check      # Biome, then astro check
   🏗️ Build site        pnpm astro build
  • package.json: adds @rrlab/astro-plugin ^0.1.0 and raises @rrlab/cli from 1.3.2 to ^1.5.0, the first version that knows the astro plugin. @astrojs/check and typescript were already devDependencies.
  • README: Local development and the CI paragraph name rr check.
  • A separate commit drops the tool list from run-run's copy. Its body and description now say "Every tool is a plugin you add." (src/content/projects/run-run.yaml, docs/content.md).

Evidence

  • Before: rr check stopped at Biome, because rr had no Astro plugin, so CI ran astro check as its own step.
    After: with a type error in src/components/Header.astro, rr check fails in its tsc section with the same diagnostic as astro check:
    rr check     ✖ check failed · tsc
                 src/components/Header.astro:71:14 - error ts(2345): Argument of type 'string' is not assignable to parameter of type 'number'.
    astro check  src/components/Header.astro:71:14 - error ts(2345): Argument of type 'string' is not assignable to parameter of type 'number'.
                 - 1 error
    
    On a clean tree, rr check passes and so do rr tsc doctor and astro build. pnpm audit reports only the fflate advisory this repo already ignores.
  • run-run copy: served the build with wrangler dev.
    • <meta name="description"> and og:description render as "One way to run the scripts in a repo. Every tool is a plugin you add." (69 characters; the schema allows 160).
    • The body fits on one line at 1280 and 834px and on two at 390px, where the last line has 6 words. No block ends on a single word, and no width scrolls horizontally.
    • The og:image uses neither field, so it doesn't change.

Merge Danger

Door: two-way

Blast Radius: CI

The type check moves into rr check, so a broken .astro or .ts file still fails the pull request, now on the Check step. The build and the deployed site don't depend on rr. The copy change shows on run-run's page and in its search and link previews.

🤖 Generated with Claude Code

https://claude.ai/code/session_01S4ufXKrCxJ4ZzpevL2fkEH

rqbazan and others added 2 commits October 17, 2026 23:30
The list named Biome, oxc, tsc and tsdown, and had already fallen behind
the official plugins. The sentence now ends at "Every tool is a plugin you
add."

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01S4ufXKrCxJ4ZzpevL2fkEH
@rrlab/astro-plugin gives rr the typecheck capability through astro check,
so `rr check` now runs Biome and then astro check. CI runs that single step
in place of `rr jsc` and `astro check`, and the README names it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01S4ufXKrCxJ4ZzpevL2fkEH
@changeset-bot

changeset-bot Bot commented Oct 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7c23f89

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://ci-rr-astro-plugin-variablelab-www.raquirozbazan.workers.dev (commit 7c23f89)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://f7214eb5-variablelab-www.raquirozbazan.workers.dev 7c23f89 2026-10-18T04:37:16.526Z Visit the dashboard ↗

@rqbazan
rqbazan merged commit 53a1060 into main Oct 18, 2026
6 checks passed
@rqbazan
rqbazan deleted the ci/rr-astro-plugin branch October 18, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant