Repository navigation
ci: type-check .astro files with rr check through @rrlab/astro-plugin - #10
Merged
Merged
Conversation
The list named Biome, oxc, tsc and tsdown, and had already fallen behind the official plugins. The sentence now ends at "Every tool is a plugin you add." Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S4ufXKrCxJ4ZzpevL2fkEH
@rrlab/astro-plugin gives rr the typecheck capability through astro check, so `rr check` now runs Biome and then astro check. CI runs that single step in place of `rr jsc` and `astro check`, and the README names it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S4ufXKrCxJ4ZzpevL2fkEH
|
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://ci-rr-astro-plugin-variablelab-www.raquirozbazan.workers.dev (commit 7c23f89)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rr checknow type-checks.astrofiles through@rrlab/astro-plugin0.1.0, which runsastro checkfor rr's type check. CI runs one step in place of two.package.json: adds@rrlab/astro-plugin ^0.1.0and raises@rrlab/clifrom1.3.2to^1.5.0, the first version that knows theastroplugin.@astrojs/checkandtypescriptwere already devDependencies.rr check.src/content/projects/run-run.yaml,docs/content.md).Evidence
rr checkstopped at Biome, because rr had no Astro plugin, so CI ranastro checkas its own step.After: with a type error in
src/components/Header.astro,rr checkfails in its tsc section with the same diagnostic asastro check:rr checkpasses and so dorr tsc doctorandastro build.pnpm auditreports only the fflate advisory this repo already ignores.wrangler dev.<meta name="description">andog:descriptionrender as "One way to run the scripts in a repo. Every tool is a plugin you add." (69 characters; the schema allows 160).og:imageuses neither field, so it doesn't change.Merge Danger
Door: two-way
Blast Radius: CI
The type check moves into
rr check, so a broken.astroor.tsfile still fails the pull request, now on the Check step. The build and the deployed site don't depend on rr. The copy change shows on run-run's page and in its search and link previews.🤖 Generated with Claude Code
https://claude.ai/code/session_01S4ufXKrCxJ4ZzpevL2fkEH