Repository navigation
docs: give the Previews Base its own build settings in Deploying - #8
Merged
Merged
Conversation
Workers Builds copies the Previews Base into each new branch's trigger. Its build command was empty, so every branch's npx wrangler preview ran without dist/ and failed. The base now has the production build command and NODE_VERSION, and Deploying lists both sets of settings. It also corrects two claims: wrangler preview does run build.command (it stays out of wrangler.jsonc so a build doesn't run Astro twice), and Workers Builds reads neither mise.toml nor mise.lock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DbUmufsTzLnGp4dve7NYP7
|
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://docs-preview-builds-variablelab-www.raquirozbazan.workers.dev (commit 19ad516)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Workers Builds: variablelab-www" check failed on every new branch. Workers Builds copies the Previews Base build settings into a new branch's trigger, and that base had no build command. So
npx wrangler previewran with nodist/.The base is now fixed in the account, not in this repo:
PATCH /accounts/{account_id}/builds/workers/{worker_tag}, withproduction_settingsunchanged byte for byte.This PR updates
README.md#deployingto match:wrangler previewdoes runbuild.command, which stays out ofwrangler.jsoncso a build doesn't run Astro twice. And Workers Builds reads neithermise.tomlnormise.lock./becomes its Preview URL.Evidence
ci/deps-security): triggerbuild_command: ""ci/preview-base-test, pushed after the PATCH, then deleted): triggerbuild_command: "pnpm exec astro build",NODE_VERSION=24build.commandinwrangler.jsonc,wrangler previewlogged[custom build] Running: pnpm exec astro build.node = "24.20.0", Workers Builds still detectednodejs@24.21.0, the image's default.Merge Danger
Door: two-way
Docs only. You can revert the account change with the same PATCH: set
build_commandback to""andenvironment_variablesto{}.Blast Radius: none
Production deploys are unchanged. Branches pushed before the PATCH keep their old trigger, but none are open.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DbUmufsTzLnGp4dve7NYP7