Repository navigation
build(release): autoPublish 改回 true #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -216,7 +216,7 @@ ab986e6 test: 故障注入场景覆盖(协议层+双适配器网络层);do | |
| | remote | origin = git@github.com:wop-platform/wop-java-sdk.git 已配置 | | ||
| | 测试/覆盖率 | 208 tests 全绿;聚合行/分支 100.00% | | ||
|
|
||
| **已按用户决策修正**:`autoPublish` true→false(首次发版人工核对后手动 Publish);release.yml 注释验证路径改为 DNS TXT(原注释写的 GitHub 仓库验证不适用于 com.wanlianyida)。 | ||
| **已按用户决策修正**:`autoPublish` true→false(首次发版人工核对后手动 Publish);release.yml 注释验证路径改为 DNS TXT(原注释写的 GitHub 仓库验证不适用于 com.wanlianyida)。(0.3.0 起改回 `true`,见 CONTRIBUTING §8) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ⚪ 低 · 发布说明相互矛盾 当维护者查阅报告以了解当前发布流程时, 更新报告中的发布策略描述及相关引用,使其与当前的自动发布流程一致。 另见 提供给 AI 智能体的提示在 `docs/wop-sdk-report-java.md` 第 219 行:
**发布说明相互矛盾**
当维护者查阅报告以了解当前发布流程时,`docs/wop-sdk-report-java.md` 声明发布需要手动点击 Publish,并提到 `autoPublish=false`;而发布指南则称 Portal 验证通过后会自动发布,因此读者会看到相互矛盾的说明。
更新报告中的发布策略描述及相关引用,使其与当前的自动发布流程一致。
另见 `docs/release-guide.md:70`。Original comment in English⚪ Low · Release instructions contradict each other When a maintainer consults the report to understand the current release process, Update the report’s release-policy description and reference to match the current automatic-publishing process. Also at Prompt for AI agentsIn `docs/wop-sdk-report-java.md` at line 219:
**Release instructions contradict each other**
When a maintainer consults the report to understand the current release process, `docs/wop-sdk-report-java.md` says releases require manual Publish and refers to `autoPublish=false`, while the release guide says Portal validation publishes automatically, so readers get conflicting instructions.
Update the report’s release-policy description and reference to match the current automatic-publishing process.
Also at `docs/release-guide.md:70`. |
||
|
|
||
| **发版前唯一阻断项**:Central Portal namespace `com.wanlianyida` 的 DNS TXT 验证(需 wanlianyida.com 域名控制权,操作指引见会话回复)。 | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -218,8 +218,8 @@ | |
| <extensions>true</extensions> | ||
| <configuration> | ||
| <publishingServerId>central</publishingServerId> | ||
| <!-- 首次发版策略:false = 上传后停在 Portal 待发布,人工核对后手动 Publish --> | ||
| <autoPublish>false</autoPublish> | ||
| <!-- 链路上线策略:true = Portal 校验通过后自动发布(发布不可撤销,坐标永久公开) --> | ||
| <autoPublish>true</autoPublish> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟠 高 · 未经批准的制品会公开发布 当匹配的 应在发布带标签的版本制品前要求明确的人工审批,而不是自动发布。 提供给 AI 智能体的提示在 `pom.xml` 第 222 行:
**未经批准的制品会公开发布**
当匹配的 `v*` 标签指向意外或恶意的提交,且该提交通过 `mvn verify` 时,发布工作流只检查标签与 POM 版本是否匹配以及 `mvn verify` 是否通过,随后 `autoPublish=true` 就会在没有人工审批环节的情况下发布带标签的制品,因此未经批准或恶意的制品会公开发布。
应在发布带标签的版本制品前要求明确的人工审批,而不是自动发布。Original comment in English🟠 High · Unapproved artifacts publish publicly When a matching Require explicit human approval before publishing tagged release artifacts instead of auto-publishing them. Prompt for AI agentsIn `pom.xml` at line 222:
**Unapproved artifacts publish publicly**
When a matching `v*` tag points to an unintended or malicious commit that passes `mvn verify`, the release workflow checks only the tag-to-POM version and `mvn verify`, then `autoPublish=true` publishes the tagged artifacts without a human approval checkpoint, so unapproved or malicious artifacts become public.
Require explicit human approval before publishing tagged release artifacts instead of auto-publishing them.There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 中 · 本地部署绕过发布关卡 当维护者配置了 Central 凭据并在本地运行发布配置的部署命令时,开发者在 GitHub Actions 之外运行 通过仅由受保护的发布工作流设置的属性来选择启用自动发布,或者以其他方式确保每次调用都执行工作流中的发布检查。 提供给 AI 智能体的提示在 `pom.xml` 第 222 行:
**本地部署绕过发布关卡**
当维护者配置了 Central 凭据并在本地运行发布配置的部署命令时,开发者在 GitHub Actions 之外运行 `mvn -P release deploy`,会激活同一个发布配置并自动发布当前检出的代码,而不会执行工作流中的标签/版本检查;因此,本地构建或未打标签的构建可能会在经过审核的版本发布之前占用一个永久性的 Central 版本号。
通过仅由受保护的发布工作流设置的属性来选择启用自动发布,或者以其他方式确保每次调用都执行工作流中的发布检查。Original comment in English🟡 Medium · Local deploy bypasses release gate When a maintainer runs the release-profile deploy command locally with Central credentials configured, a developer running Make automatic publishing opt-in via a property set only by the guarded release workflow, or otherwise enforce the workflow’s release checks for every invocation. Prompt for AI agentsIn `pom.xml` at line 222:
**Local deploy bypasses release gate**
When a maintainer runs the release-profile deploy command locally with Central credentials configured, a developer running `mvn -P release deploy` outside GitHub Actions activates this same release profile and automatically publishes the current checkout, without the workflow’s tag/version check; a local or untagged build can therefore consume a permanent Central version before the reviewed release.
Make automatic publishing opt-in via a property set only by the guarded release workflow, or otherwise enforce the workflow’s release checks for every invocation.There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟠 高 · 重新打标签会发布过时制品 当版本标签在原始发布任务仍在运行时被删除并重新指向另一个提交时,原始任务可能通过 当标签被重新指向时,取消正在进行的发布任务,并且只有在标签仍指向任务检出的提交时才允许上传。 另见 提供给 AI 智能体的提示在 `pom.xml` 第 222 行:
**重新打标签会发布过时制品**
当版本标签在原始发布任务仍在运行时被删除并重新指向另一个提交时,原始任务可能通过 `autoPublish=true` 发布其检出的提交,从而永久占用该版本号;之后,较新的运行会被拒绝,旧制品则继续公开。
当标签被重新指向时,取消正在进行的发布任务,并且只有在标签仍指向任务检出的提交时才允许上传。
另见 `docs/release-guide.md:78-79`。Original comment in English🟠 High · Retagged release publishes stale artifacts When a version tag is deleted and repushed to a different commit while the original release job is still running, the original job can publish its checked-out commit through Cancel in-flight release jobs when a tag is retargeted and gate upload on the tag still pointing to the job’s checked-out commit. Also at Prompt for AI agentsIn `pom.xml` at line 222:
**Retagged release publishes stale artifacts**
When a version tag is deleted and repushed to a different commit while the original release job is still running, the original job can publish its checked-out commit through `autoPublish=true`, permanently occupying the version; the newer run is then rejected and the older artifacts remain public.
Cancel in-flight release jobs when a tag is retargeted and gate upload on the tag still pointing to the job’s checked-out commit.
Also at `docs/release-guide.md:78-79`. |
||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 中 · 丢弃说明无法阻止发布
当操作人员在上传前发现版本存在问题并按照丢弃说明操作时,指南会要求他们丢弃一个尚不存在的部署;上传后,
autoPublish=true会在验证通过后立即发布,因此没有可用于阻止错误发布的丢弃时限。请用新的指导替换“丢弃并重新打标签”的恢复说明,明确指出:上传前没有可供丢弃的部署,而自动发布后也不存在丢弃时限。
提供给 AI 智能体的提示
Original comment in English
🟡 Medium · Discard guidance cannot stop release
When an operator finds a release issue before upload and follows the discard instruction, the guide directs operators to discard a deployment that does not yet exist; after upload,
autoPublish=truepublishes it as soon as validation passes, leaving no discard window to stop an erroneous release.Replace the discard-and-retag recovery instruction with guidance that reflects there is no deployment to discard before upload and no discard window after automatic publication.
Prompt for AI agents