Skip to content

chore: keep lockfile registry-agnostic - #89

Merged
peakematt merged 1 commit into
mainfrom
chore/help-722-omit-lockfile-registry-resolved
Sep 11, 2026
Merged

peakematt merged 1 commit into
mainfrom
chore/help-722-omit-lockfile-registry-resolved

Conversation

@peakematt

Copy link
Copy Markdown
Contributor

HELP-722 requires committed public SDK lockfiles to be independent of the registry used to generate them. The current lockfile records registry-specific resolved URLs, which couples it to the effective install registry.

This adds omit-lockfile-registry-resolved=true and regenerates the existing lockfile without changing dependencies.

Verification found 593 registry resolved entries removed and all 593 integrity values preserved. Versions, package records, dependency relationships, non-registry resolutions, and lockfile version are unchanged. There are zero Socket Firewall host references and zero semantic verifier violations.

The branch was regenerated and checked with Node v22.23.2 and npm 10.9.8:

npm install --package-lock-only --ignore-scripts --no-audit --no-fund
npm ci --registry=https://registry.npmjs.org/
npm run prettier
npm run lint
npm run build
npm test -- --coverage

The clean public-registry install left the lockfile unchanged. This draft should remain unmerged until the earlier workos-node rollout and downstream lockfile-command validation are complete; no reviewer action is requested yet.

HELP-722: https://linear.app/workos/issue/HELP-722

@linear-code

linear-code Bot commented Sep 3, 2026

Copy link
Copy Markdown

HELP-722

@peakematt
peakematt marked this pull request as ready for review September 3, 2026 15:04

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge when its documented rollout dependency is complete.

Summary

  • Adds omit-lockfile-registry-resolved=true to .npmrc.
  • Removes registry-hosted resolved URLs while preserving dependency versions, integrity hashes, and package relationships.

Reviews (2) · Last reviewed commit: "chore: keep lockfile registry-agnostic"

@peakematt
peakematt force-pushed the chore/help-722-omit-lockfile-registry-resolved branch from 180d726 to 8aae342 Compare September 11, 2026 15:31
@peakematt
peakematt merged commit c4a3ffc into main Sep 11, 2026
5 checks passed
@peakematt
peakematt deleted the chore/help-722-omit-lockfile-registry-resolved branch September 11, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants