Repository navigation
fix(semgrep): include PCP component fixtures in scans - #1475
Closed
ShevchenkoRostyslav wants to merge 1 commit into
Closed
ShevchenkoRostyslav wants to merge 1 commit into
ShevchenkoRostyslav wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Semgrep's default test-directory exclusions skip the serialized PCP component fixtures. Include
pcp-defs/rust/tests/fixtures/**through a narrow Semgrepignore v2 exception while retaining the default exclusions and the PCP fixture exception.Stacked on #1473. Merge that PR first, then retarget this PR to
main.Validation: a synthetic directory scan with Semgrep 1.168.0 included all four fixture targets, including nested test directories and
.tar.gzpointers; nine unrelated test/build/vendor paths stayed excluded, with zero scan errors. Whitespace checks passed. Managed project/global ignore settings must also allow these paths.AI assistance was used to prepare and validate this change.