Skip to content

fix(pcp): zeroize sensitive data on drop - #1478

Merged
pophilpo merged 1 commit into
mainfrom
vm/zeorize-pcp-and-defs
Nov 6, 2026
Merged

pophilpo merged 1 commit into
mainfrom
vm/zeorize-pcp-and-defs

Conversation

@vmenge

@vmenge vmenge commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

fulfills requirements set by the security team by adding zeroization on drop to biometric protobuf messages, encoded iris payloads, prepared face embeddings, metadata JSON, and plaintext diagnostic tiers.

uses Zeroize and ZeroizeOnDrop derives and adjusts existing callers for Drop.

@vmenge
vmenge requested a review from a team as a code owner November 6, 2026 16:46
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

No concrete issues found in the PR changes. The zeroization derives and caller adjustments appear consistent with the affected types.

Review was static; tests were not run in the read-only environment.

@pophilpo
pophilpo merged commit 53ba3ca into main Nov 6, 2026
28 checks passed
@pophilpo
pophilpo deleted the vm/zeorize-pcp-and-defs branch November 6, 2026 17:34

@ShevchenkoRostyslav ShevchenkoRostyslav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants