Repository navigation
feat(pcp-defs): export reference image enums over uniffi - #1479
Merged
Merged
Conversation
|
No concrete issues found in the changes introduced by this PR. Build and test execution was not verified in this read-only environment. |
vmenge
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lets oxide export the reference image enums to kotlin/swift straight from pcp-defs, instead of keeping its own copy
Notes
uniffifeature, off by default - orb builds dont changeuniffi::EnumonReferenceImage.MatchModeandMatchStatusviabuild.rs, same way zeroize is added todayforbid(unsafe_code)stays, uniffi compiles under itfs-err3.1.3 -> 3.3.2, uniffi needs it-D warnings, fmt andcargo test -p orb-pcp-defswith and without the featureTest