Skip to content

test(pcp): enable roundtrip coverage with a complete dummy fixture - #1481

Merged
vmenge merged 7 commits into
mainfrom
vm/dummy-pcp-round-trip
Nov 11, 2026
Merged

vmenge merged 7 commits into
mainfrom
vm/dummy-pcp-round-trip

Conversation

@vmenge

@vmenge vmenge commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

replace the ignored fixture tests with an active roundtrip test using a dummy PCP archive tracked in Git LFS.

the fixture was generated from orb-core main at commit 8bdd896afe0b764df23cc5d27ecef6f127bdad75, the latest commit at generation time, before orb-core adopted the shared PCP builder. this provides an independent reference for the builder under test.

cover all eight fraud images and multiframe iris captures, preserving payload and metadata comparisons, manifest verification, and rebuilt signature checks.

files must match byte-for-byte, except:

  • Hyrax commitments and blinding factors: rebuilding uses fresh randomness, so these bytes change. we check that the files are nonempty and have the same size, but not that the commitments are mathematically correct.
  • info.json: values must match, except for newly generated salts. JSON spacing and field order don't matter.
  • hashes.json: hashes must match the files they describe, and the package version must be correct. JSON spacing and field order don't matter.
  • hashes.sign: we check that the new signature is valid. we don't compare it with, or verify, the original signature.
  • tar archives: we compare the files inside, using the rules above. we don't compare file order or archive details such as timestamps and padding.
  • gzip archives: we check the stored filename and timestamp, but don't require the compressed bytes or other header details to match.

@vmenge
vmenge requested a review from a team as a code owner November 11, 2026 13:43
@github-actions

Copy link
Copy Markdown

No concrete issues found in the PR changes. CI already fetches LFS assets. I couldn’t validate the fixture contents or run the roundtrip test because this checkout contains only the LFS pointer.

@github-actions

Copy link
Copy Markdown

No concrete issues found in the PR changes. Fixture validation and test execution were limited because the new archive is present only as a Git LFS pointer in this checkout.

@github-actions

Copy link
Copy Markdown

No concrete issues found in the PR changes. The roundtrip test preserves payload, metadata, manifest, and signature checks while adding fraud images and multiframe captures.

Validation is limited to code inspection: the fixture is an unresolved Git LFS pointer in this checkout, so I could not verify its contents or run the roundtrip test.

@github-actions

Copy link
Copy Markdown

No concrete issues found in the PR changes.

Validation was limited to static review: the fixture is an unresolved Git LFS pointer in this checkout, so I couldn’t verify its contents or run the roundtrip test.

@github-actions

Copy link
Copy Markdown

No concrete issues found in the PR changes. I couldn’t run the roundtrip test because this checkout contains only the Git LFS pointer for the fixture.

@vmenge
vmenge merged commit e7328e2 into main Nov 11, 2026
25 of 26 checks passed
@vmenge
vmenge deleted the vm/dummy-pcp-round-trip branch November 11, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants