Repository navigation
test(pcp): enable roundtrip coverage with a complete dummy fixture - #1481
Conversation
|
No concrete issues found in the PR changes. CI already fetches LFS assets. I couldn’t validate the fixture contents or run the roundtrip test because this checkout contains only the LFS pointer. |
|
No concrete issues found in the PR changes. Fixture validation and test execution were limited because the new archive is present only as a Git LFS pointer in this checkout. |
|
No concrete issues found in the PR changes. The roundtrip test preserves payload, metadata, manifest, and signature checks while adding fraud images and multiframe captures. Validation is limited to code inspection: the fixture is an unresolved Git LFS pointer in this checkout, so I could not verify its contents or run the roundtrip test. |
…ftware into vm/dummy-pcp-round-trip
|
No concrete issues found in the PR changes. Validation was limited to static review: the fixture is an unresolved Git LFS pointer in this checkout, so I couldn’t verify its contents or run the roundtrip test. |
|
No concrete issues found in the PR changes. I couldn’t run the roundtrip test because this checkout contains only the Git LFS pointer for the fixture. |
replace the ignored fixture tests with an active roundtrip test using a dummy PCP archive tracked in Git LFS.
the fixture was generated from orb-core main at commit 8bdd896afe0b764df23cc5d27ecef6f127bdad75, the latest commit at generation time, before orb-core adopted the shared PCP builder. this provides an independent reference for the builder under test.
cover all eight fraud images and multiframe iris captures, preserving payload and metadata comparisons, manifest verification, and rebuilt signature checks.
files must match byte-for-byte, except:
info.json: values must match, except for newly generated salts. JSON spacing and field order don't matter.hashes.json: hashes must match the files they describe, and the package version must be correct. JSON spacing and field order don't matter.hashes.sign: we check that the new signature is valid. we don't compare it with, or verify, the original signature.