Skip to content

Simplify _wp_filter_build_unique_id() to use spl_object_id() #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 2 commits into from
Aug 16, 2026
+12 −28
Merged

Simplify _wp_filter_build_unique_id() to use spl_object_id() #105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
761ef88
Use spl_object_id() instead of spl_object_hash() in the router
claude Aug 16, 2026
1f7f6bd
Silence unused-parameter warning for $priority
claude Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 12 additions & 28 deletions router.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,49 +25,33 @@ function add_filter( $tag, $function_to_add, $priority = 10, $accepted_args = 1
/**
* This is a copy of WordPress's _wp_filter_build_unique_id() function.
*
* We duplicate it because WordPress is not loaded yet.
* We duplicate it because WordPress is not loaded yet. It cannot use
* `WP_CLI::add_wp_hook()` either, as this file is executed by PHP's built-in
* web server in a separate process where WP-CLI is not loaded.
*/
function _wp_filter_build_unique_id( $tag, $callback, $priority ) {
global $wp_filter;
static $filter_id_count = 0;

function _wp_filter_build_unique_id( $tag, $callback, $priority ) { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.FoundAfterLastUsed -- $priority retained to match core's _wp_filter_build_unique_id() signature.
if ( is_string( $callback ) ) {
return $callback;
}

if ( is_object( $callback ) ) {
// Closures are currently implemented as objects
$callback = array( $callback, '' );
} else {
$callback = (array) $callback;
return (string) spl_object_id( $callback );
}

if ( ! isset( $callback[1] ) || ! is_string( $callback[1] ) ) {
return null;
}

if ( is_object( $callback[0] ) ) {
// Object Class Calling
if ( function_exists( 'spl_object_hash' ) ) {
return spl_object_hash( $callback[0] ) . $callback[1];
} else {
$obj_idx = get_class( $callback[0] ) . $callback[1];
if ( ! isset( $callback[0]->wp_filter_id ) ) {
if ( false === $priority ) {
return false;
}
$obj_idx .= isset( $wp_filter[ $tag ][ $priority ] )
? count( (array) $wp_filter[ $tag ][ $priority ] )
: $filter_id_count;

$callback[0]->wp_filter_id = $filter_id_count;
++$filter_id_count;
} else {
$obj_idx .= $callback[0]->wp_filter_id;
}

return $obj_idx;
}
return ( (string) spl_object_id( $callback[0] ) ) . $callback[1];
} elseif ( is_string( $callback[0] ) ) {
// Static Calling
return $callback[0] . '::' . $callback[1];
}

return null;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}

function _get_full_host( $url ) {
Expand Down