You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(previews): preview doesn't work as expected when Faust configured #233
changed the title [-]fix(previews): iframe preview doesn't work when Faust configured[/-][+]fix(previews): preview doesn't work as expected when Faust configured[/+]on May 30, 2025
@colinmurphy @wpengine/headless-open-source
Redirected previews conflict will be fixed with #240. iframe conflict however is a bit complicated. Faust provides a filter to disable frontend redirects for the specific URLs, but those URLs have to be exact match. Thus all the preview URLs have to be supplied to that filter to disable redirects as far as I understand.
On the other hand, and more importantly we don't want to suppress the redirect feature of Faust (an independent plugin) for an optional feature (iframe) of HWP Previews. Instead I'll document this conflict in #229 and provide an instruction on how to resolve this conflict, by removing frontend_url from Faust.
Thanks for so much context here. I think that sounds like a good approach. We might consider at some point in a breaking change to remove previews from Faust too which I guess would solve this issue too?
@colinmurphy we already remove the previews link replacement functionality of Faust by enabling the HWP Previews with #240. The iframe issue here is related to "redirect all to frontend" feature of Faust which is not connected to the previews. That's why I think we shouldn't do anything about it. If users want to use iframe with Faust, they can disable the redirect functionality by removing frontend url from the settings, and I'll document this fix.
@colinmurphy we already remove the previews link replacement functionality of Faust by enabling the HWP Previews with #240. The iframe issue here is related to "redirect all to frontend" feature of Faust which is not connected to the previews. That's why I think we shouldn't do anything about it. If users want to use iframe with Faust, they can disable the redirect functionality by removing frontend url from the settings, and I'll document this fix.
Wouldn't removing the front-end URL from Faust config also break link rewrites? Not sure that's a viable fix for this issue.
Activity
colinmurphy commentedon May 29, 2025
@ahuseyn @wpengine/headless-open-source @wpengine-cpierce
One option might be:
[-]fix(previews): iframe preview doesn't work when Faust configured[/-][+]fix(previews): preview doesn't work as expected when Faust configured[/+]ahuseyn commentedon Jun 5, 2025
@colinmurphy @wpengine/headless-open-source
Redirected previews conflict will be fixed with #240. iframe conflict however is a bit complicated. Faust provides a filter to disable frontend redirects for the specific URLs, but those URLs have to be exact match. Thus all the preview URLs have to be supplied to that filter to disable redirects as far as I understand.
On the other hand, and more importantly we don't want to suppress the redirect feature of Faust (an independent plugin) for an optional feature (iframe) of HWP Previews. Instead I'll document this conflict in #229 and provide an instruction on how to resolve this conflict, by removing frontend_url from Faust.
colinmurphy commentedon Jun 5, 2025
@ahuseyn
Thanks for so much context here. I think that sounds like a good approach. We might consider at some point in a breaking change to remove previews from Faust too which I guess would solve this issue too?
ahuseyn commentedon Jun 6, 2025
@colinmurphy we already remove the previews link replacement functionality of Faust by enabling the HWP Previews with #240. The iframe issue here is related to "redirect all to frontend" feature of Faust which is not connected to the previews. That's why I think we shouldn't do anything about it. If users want to use iframe with Faust, they can disable the redirect functionality by removing frontend url from the settings, and I'll document this fix.
moonmeister commentedon Jun 6, 2025
Wouldn't removing the front-end URL from Faust config also break link rewrites? Not sure that's a viable fix for this issue.