Repository navigation
chore(deps-dev): drop @wordpress/scripts and share one Playwright config - #835
Open
josephfusco wants to merge 4 commits into
Open
josephfusco wants to merge 4 commits into
josephfusco wants to merge 4 commits into
Conversation
The plugin configs spread @wordpress/scripts' Playwright config, the only thing wp-scripts was used for. A root playwright.config.base.js carries the same settings, and the plugins run plain `playwright test`.
…wright to 3.1 - Remove @wordpress/scripts and the unused @wordpress/jest-console from the root and plugins. - Remove the Playwright tooling from wpgraphql-debug-extensions and wpgraphql-webhooks, which have no E2E tests. - Bump @wordpress/e2e-test-utils-playwright to ^3.1.0, which needs Node 22.19+, so raise the root engines field to match.
josephfusco
requested review from
a team,
colinmurphy and
wpe-ie-deploy-bot
as code owners
October 23, 2026 14:59
|
Contributor
📦 Plugin Artifacts Ready!Download from GitHub Actions run Available plugins:
See the "Artifacts" section at the bottom of the Actions run page |
Contributor
🔍 WordPress Plugin Check Report
📊 Report
❌ Errors (38)📁 examples/hwp-preview-rest/wp-env/uploads.zip (1 error)
📁 examples/hwp-preview-wpgraphql/wp-env/uploads.zip (1 error)
📁 examples/hwp-preview-rest/wp-env/setup/.htaccess (1 error)
📁 examples/hwp-preview-rest/.wp-env.json (1 error)
📁 examples/hwp-preview-wpgraphql/wp-env/setup/.htaccess (1 error)
📁 examples/hwp-preview-wpgraphql/wp-env/__MACOSX/._uploads (1 error)
📁 examples/hwp-preview-wpgraphql/.wp-env.json (1 error)
📁 examples/hwp-preview-astro/wp-env/setup/.htaccess (1 error)
📁 examples/hwp-preview-astro/.wp-env.json (1 error)
📁 .env.dist (2 errors)
📁 docs/.gitkeep (1 error)
📁 .docker/.env.ci (1 error)
📁 .editorconfig (1 error)
📁 .wp-env.json (1 error)
📁 phpstan.neon.dist (1 error)
📁 bin/build-docker.sh (1 error)
📁 bin/_lib.sh (1 error)
📁 bin/sync-package-version.sh (1 error)
📁 bin/run-codeception.sh (1 error)
📁 bin/install-plugins.sh (1 error)
📁 bin/install-test-env.sh (1 error)
📁 bin/local/run-e2e-tests.sh (1 error)
📁 bin/local/setup-docker-env.sh (1 error)
📁 bin/local/run-qa.sh (1 error)
📁 bin/local/run-unit-tests.sh (1 error)
📁 .docker/init-docker.sh (1 error)
📁 examples/hwp-preview-wpgraphql/example-app/src/pages/[identifier].js (1 error)
📁 examples/hwp-preview-astro/example-app/src/pages/[...uri].astro (1 error)
📁 hwp-previews.php (3 errors)
📁 readme.txt (2 errors)
📁 activation.php (1 error)
📁 deactivation.php (1 error)
📁 src/Templates/admin.php (1 error)
📁 src/Templates/iframe.php (1 error)
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears 15 of the 17 Dependabot alerts on the root
pnpm-lock.yaml, and removes a build toolchain from a repo meant to ship from source with no build step.Why
@wordpress/scriptswas used for exactly one thing:wp-scripts test-playwrightand its base Playwright config, in the plugin e2e suites. In exchange it pulled in webpack, Babel, stylelint, markdownlint, and Jest, which broughtmarkdown-it,uuid,postcss-selector-parser,@babel/core, and others into the alerts.@wordpress/jest-consolewasn't imported anywhere.What changes
playwright.config.base.jsat the root has the same settings as the wp-scripts config, minus its global setup, which every plugin already replaced with its own. hwp-previews, wpgraphql-logging, and hwp-documents import it by relative path and run plainplaywright test. Nothing is generated or copied.@wordpress/scriptsand@wordpress/jest-consolefrom the root and the plugins.@wordpress/e2e-test-utils-playwrightfrom 1.54 to 3.1, which clears theextract-zipand OpenTelemetry alerts. Its breaking changes are a higher Node minimum and two helpers (switchEditorToolandsetGutenbergExperiments) that no spec uses.engines.nodeto>=22.19.0, which e2e-test-utils 3.x requires. CI already runs Node 24, and.nvmrcislts/krypton.pnpm-lock.yamldrops about 12,600 lines.pnpm exec playwright install --with-deps chromium) instead ofpnpm dlx, which fetched the newest Playwright and could drift from the locked@playwright/test. It now installs Chromium only, since that's the only project the config runs.Remaining alerts
http-cache-semanticscomes in through@wordpress/env12, which is already the latest, and there's no upstream fix.bracesis a withdrawn advisory.Testing
playwright test --listloads each plugin's config and finds every spec: hwp-previews 20 tests, wpgraphql-logging 8, hwp-documents 3.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with tracing the Dependabot alerts to their source, replacing the wp-scripts Playwright config, and updating dependencies.