Skip to content

fix(logging): resolve Plugin Check errors in the shipped plugin - #837

Open
josephfusco wants to merge 5 commits into
mainfrom
fix/logging-plugin-check
Open

josephfusco wants to merge 5 commits into
mainfrom
fix/logging-plugin-check

Conversation

@josephfusco

@josephfusco josephfusco commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Fixes the real errors Plugin Check reports for the wpgraphql-logging zip, as opposed to the dev-file false positives #830 removes. One commit per fix:

  • Requires PHP: 8.1.2+ → 8.1.2. Plugin Check only accepts a plain version, and the + also made it not match readme.txt.
  • ABSPATH guards in the six files that lacked one: activation.php, deactivation.php, the settings page template, ListTable.php, and the log view and notice templates. They match the guard already used in WPGraphQLLoggerList.php, placed after the use block.
  • phpcs:ignore on the CSV export's fclose(). It closes the php://output stream, which WP_Filesystem can't handle, so the comment records why.
  • License: composer.json said "GPLv2 or later", which isn't a valid SPDX identifier, so it now says GPL-2.0-or-later. readme.txt now uses the header's "GPLv2 or later" wording.

Testing

  • Built the plugin zip with composer archive and ran wp plugin check wpgraphql-logging locally in wp-env, using the same options as the workflow in ci: run Plugin Check on the built plugin archive #830. The only error left is "Tested up to: 6.9 < 7.1".
  • php -l, phpcs, and phpstan pass.

Not changed

"Tested up to" stays 6.9, the newest WordPress version the CI matrix tests.

Merging this adds these fixes to the pending 1.0.2 release PR (#827).

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with running Plugin Check locally and fixing the errors it reported.

@josephfusco
josephfusco requested review from a team and colinmurphy as code owners October 23, 2026 15:39
@josephfusco josephfusco added [Type] Bug An existing feature is broken [Area] Logging Issues for the WPGraphQL Logging plugin Security Work relates to vulnerabilities or hardening labels Oct 23, 2026
@changeset-bot

changeset-bot Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9fbe16f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

📦 Plugin Artifacts Ready!

Download from GitHub Actions run

Available plugins:

  • ✅ wpgraphql-logging.zip

See the "Artifacts" section at the bottom of the Actions run page

@github-actions

Copy link
Copy Markdown
Contributor

🔍 WordPress Plugin Check Report

❌ Status: Failed

📊 Report

🎯 Total Issues ❌ Errors ⚠️ Warnings
26 26 0

❌ Errors (26)

📁 examples/wpgraphql-logging-nextjs/wp-env/uploads.zip (1 error)
📍 Line 🔖 Check 💬 Message
0 compressed_files Compressed files are not permitted.
📁 examples/wpgraphql-logging-nextjs/wp-env/setup/.htaccess (1 error)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
📁 examples/wpgraphql-logging-nextjs/.wp-env.json (1 error)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
📁 .env.dist (2 errors)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
0 application_detected Application files are not permitted.
📁 .docker/.env.ci (1 error)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
📁 assets/.gitkeep (1 error)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
📁 .editorconfig (1 error)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
📁 wp-env/setup/.htaccess (1 error)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
📁 .wp-env.json (1 error)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
📁 src/Logger/.gitkeep (1 error)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
📁 phpstan.neon.dist (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/build-docker.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/_lib.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/sync-package-version.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/run-codeception.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/install-plugins.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/install-test-env.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/local/run-e2e-tests.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/local/setup-docker-env.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/local/run-qa.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/local/run-unit-tests.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 .docker/init-docker.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 examples/wpgraphql-logging-nextjs/example-app/src/pages/[slug].js (1 error)
📍 Line 🔖 Check 💬 Message
0 badly_named_files File and folder names must not contain spaces or special characters.
📁 wpgraphql-logging.php (1 error)
📍 Line 🔖 Check 💬 Message
0 plugin_updater_detected Including An Update Checker / Changing Updates functionality. Plugin Updater detected. Use of the Update URI header is not allowed in plugins hosted on WordPress.org.
📁 readme.txt (1 error)
📍 Line 🔖 Check 💬 Message
0 outdated_tested_upto_header Tested up to: 6.9 < 7.1. The "Tested up to" value in your plugin is not set to the current version of WordPress. This means your plugin will not show up in searches, as we require plugins to be compatible and documented as tested up to the most recent version of WordPress.

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

composer.json used "GPLv2 or later", which isn't a valid SPDX identifier. readme.txt now
uses the same "GPLv2 or later" wording as the plugin header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Logging Issues for the WPGraphQL Logging plugin Security Work relates to vulnerabilities or hardening [Type] Bug An existing feature is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant