Repository navigation
fix(logging): resolve Plugin Check errors in the shipped plugin - #837
Open
josephfusco wants to merge 5 commits into
Open
josephfusco wants to merge 5 commits into
josephfusco wants to merge 5 commits into
Conversation
Plugin Check rejects "8.1.2+" and flags the mismatch with readme.txt, which says 8.1.2.
|
Contributor
📦 Plugin Artifacts Ready!Download from GitHub Actions run Available plugins:
See the "Artifacts" section at the bottom of the Actions run page |
Contributor
🔍 WordPress Plugin Check Report
📊 Report
❌ Errors (26)📁 examples/wpgraphql-logging-nextjs/wp-env/uploads.zip (1 error)
📁 examples/wpgraphql-logging-nextjs/wp-env/setup/.htaccess (1 error)
📁 examples/wpgraphql-logging-nextjs/.wp-env.json (1 error)
📁 .env.dist (2 errors)
📁 .docker/.env.ci (1 error)
📁 assets/.gitkeep (1 error)
📁 .editorconfig (1 error)
📁 wp-env/setup/.htaccess (1 error)
📁 .wp-env.json (1 error)
📁 src/Logger/.gitkeep (1 error)
📁 phpstan.neon.dist (1 error)
📁 bin/build-docker.sh (1 error)
📁 bin/_lib.sh (1 error)
📁 bin/sync-package-version.sh (1 error)
📁 bin/run-codeception.sh (1 error)
📁 bin/install-plugins.sh (1 error)
📁 bin/install-test-env.sh (1 error)
📁 bin/local/run-e2e-tests.sh (1 error)
📁 bin/local/setup-docker-env.sh (1 error)
📁 bin/local/run-qa.sh (1 error)
📁 bin/local/run-unit-tests.sh (1 error)
📁 .docker/init-docker.sh (1 error)
📁 examples/wpgraphql-logging-nextjs/example-app/src/pages/[slug].js (1 error)
📁 wpgraphql-logging.php (1 error)
📁 readme.txt (1 error)
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
composer.json used "GPLv2 or later", which isn't a valid SPDX identifier. readme.txt now uses the same "GPLv2 or later" wording as the plugin header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the real errors Plugin Check reports for the wpgraphql-logging zip, as opposed to the dev-file false positives #830 removes. One commit per fix:
Requires PHP: 8.1.2+→8.1.2. Plugin Check only accepts a plain version, and the+also made it not matchreadme.txt.ABSPATHguards in the six files that lacked one:activation.php,deactivation.php, the settings page template,ListTable.php, and the log view and notice templates. They match the guard already used inWPGraphQLLoggerList.php, placed after theuseblock.phpcs:ignoreon the CSV export'sfclose(). It closes thephp://outputstream, which WP_Filesystem can't handle, so the comment records why.composer.jsonsaid "GPLv2 or later", which isn't a valid SPDX identifier, so it now saysGPL-2.0-or-later.readme.txtnow uses the header's "GPLv2 or later" wording.Testing
composer archiveand ranwp plugin check wpgraphql-logginglocally in wp-env, using the same options as the workflow in ci: run Plugin Check on the built plugin archive #830. The only error left is "Tested up to: 6.9 < 7.1".php -l,phpcs, andphpstanpass.Not changed
"Tested up to" stays 6.9, the newest WordPress version the CI matrix tests.
Merging this adds these fixes to the pending 1.0.2 release PR (#827).
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with running Plugin Check locally and fixing the errors it reported.