Skip to content

chore: suppress new Psalm 6.20.1 errors in previews and logging - #847

Merged
josephfusco merged 1 commit into
mainfrom
chore/psalm-6-20-fixes
Oct 26, 2026
Merged

josephfusco merged 1 commit into
mainfrom
chore/psalm-6-20-fixes

Conversation

@josephfusco

Copy link
Copy Markdown
Member

Psalm 6.20.1 (#833, #834) added errors that now fail code quality on main and on every PR that touches these plugins (for example #837 and #838).

  • hwp-previews: 10 MissingOverrideAttribute errors. Suppressed the same way wpgraphql-logging/psalm.xml already does.
  • wpgraphql-logging: 3 PossiblyInvalidArgument errors on register_activation_hook / register_deactivation_hook. WordPress passes $network_wide to these callbacks, and PHP ignores the extra argument, so the code is fine. Added the two files to the existing suppression, the same way hwp-previews/psalm.xml handles hwp-previews.php.

Verified locally: composer run-script php:psalm and check-cs pass for both plugins.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with diagnosing the CI failures and writing the Psalm config changes.

Psalm 6.20.1 reports MissingOverrideAttribute in hwp-previews and PossiblyInvalidArgument on the activation and deactivation hooks in wpgraphql-logging. Both now fail code quality on main and on every PR that touches either plugin. Follow the suppressions each plugin's sibling already uses.
@josephfusco josephfusco added the [Area] Previews Issues for the HWP Previews plugin label Oct 26, 2026
@josephfusco josephfusco added [Type] Task Maintenance, upkeep, and other non-functional work [Area] Logging Issues for the WPGraphQL Logging plugin labels Oct 26, 2026
@josephfusco
josephfusco requested a review from a team as a code owner October 26, 2026 12:11
@changeset-bot

changeset-bot Bot commented Oct 26, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d44ef6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

🔍 WordPress Plugin Check Report

❌ Status: Failed

📊 Report

🎯 Total Issues ❌ Errors ⚠️ Warnings
35 35 0

❌ Errors (35)

📁 examples/wpgraphql-logging-nextjs/wp-env/uploads.zip (1 error)
📍 Line 🔖 Check 💬 Message
0 compressed_files Compressed files are not permitted.
📁 examples/wpgraphql-logging-nextjs/wp-env/setup/.htaccess (1 error)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
📁 examples/wpgraphql-logging-nextjs/.wp-env.json (1 error)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
📁 .env.dist (2 errors)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
0 application_detected Application files are not permitted.
📁 .docker/.env.ci (1 error)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
📁 assets/.gitkeep (1 error)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
📁 .editorconfig (1 error)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
📁 wp-env/setup/.htaccess (1 error)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
📁 .wp-env.json (1 error)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
📁 src/Logger/.gitkeep (1 error)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
📁 phpstan.neon.dist (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/build-docker.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/_lib.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/sync-package-version.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/run-codeception.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/install-plugins.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/install-test-env.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/local/run-e2e-tests.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/local/setup-docker-env.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/local/run-qa.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/local/run-unit-tests.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 .docker/init-docker.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 examples/wpgraphql-logging-nextjs/example-app/src/pages/[slug].js (1 error)
📍 Line 🔖 Check 💬 Message
0 badly_named_files File and folder names must not contain spaces or special characters.
📁 wpgraphql-logging.php (2 errors)
📍 Line 🔖 Check 💬 Message
0 plugin_header_invalid_requires_php The "Requires PHP" header in the plugin file should only contain a PHP version such as "5.2.4" or "7.0".
0 plugin_updater_detected Including An Update Checker / Changing Updates functionality. Plugin Updater detected. Use of the Update URI header is not allowed in plugins hosted on WordPress.org.
📁 src/Admin/View/Download/DownloadLogService.php (1 error)
📍 Line 🔖 Check 💬 Message
65 WordPress.WP.AlternativeFunctions.file_system_operations_fclose File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: fclose().
📁 readme.txt (2 errors)
📍 Line 🔖 Check 💬 Message
0 outdated_tested_upto_header Tested up to: 6.9 < 7.1. The "Tested up to" value in your plugin is not set to the current version of WordPress. This means your plugin will not show up in searches, as we require plugins to be compatible and documented as tested up to the most recent version of WordPress.
0 readme_mismatched_header_requires_php Mismatched Requires PHP: 8.1.2 != 8.1.2+. "Requires PHP" needs to be exactly the same with that in your main plugin file's header.
📁 activation.php (1 error)
📍 Line 🔖 Check 💬 Message
0 missing_direct_file_access_protection PHP file should prevent direct access. Add a check like: if ( ! defined( 'ABSPATH' ) ) exit;
📁 deactivation.php (1 error)
📍 Line 🔖 Check 💬 Message
0 missing_direct_file_access_protection PHP file should prevent direct access. Add a check like: if ( ! defined( 'ABSPATH' ) ) exit;
📁 src/Admin/View/Templates/WPGraphQLLoggerView.php (1 error)
📍 Line 🔖 Check 💬 Message
0 missing_direct_file_access_protection PHP file should prevent direct access. Add a check like: if ( ! defined( 'ABSPATH' ) ) exit;
📁 src/Admin/View/Templates/WPGraphQLLoggerNotice.php (1 error)
📍 Line 🔖 Check 💬 Message
0 missing_direct_file_access_protection PHP file should prevent direct access. Add a check like: if ( ! defined( 'ABSPATH' ) ) exit;
📁 src/Admin/View/List/ListTable.php (1 error)
📍 Line 🔖 Check 💬 Message
0 missing_direct_file_access_protection PHP file should prevent direct access. Add a check like: if ( ! defined( 'ABSPATH' ) ) exit;
📁 src/Admin/Settings/Templates/admin.php (1 error)
📍 Line 🔖 Check 💬 Message
0 missing_direct_file_access_protection PHP file should prevent direct access. Add a check like: if ( ! defined( 'ABSPATH' ) ) exit;

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

@josephfusco
josephfusco merged commit b5dbf5e into main Oct 26, 2026
3 of 5 checks passed
@josephfusco
josephfusco deleted the chore/psalm-6-20-fixes branch October 26, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Logging Issues for the WPGraphQL Logging plugin [Area] Previews Issues for the HWP Previews plugin [Type] Task Maintenance, upkeep, and other non-functional work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant