Repository navigation
chore: suppress new Psalm 6.20.1 errors in previews and logging - #847
Merged
Merged
Conversation
Psalm 6.20.1 reports MissingOverrideAttribute in hwp-previews and PossiblyInvalidArgument on the activation and deactivation hooks in wpgraphql-logging. Both now fail code quality on main and on every PR that touches either plugin. Follow the suppressions each plugin's sibling already uses.
|
Contributor
🔍 WordPress Plugin Check Report
📊 Report
❌ Errors (35)📁 examples/wpgraphql-logging-nextjs/wp-env/uploads.zip (1 error)
📁 examples/wpgraphql-logging-nextjs/wp-env/setup/.htaccess (1 error)
📁 examples/wpgraphql-logging-nextjs/.wp-env.json (1 error)
📁 .env.dist (2 errors)
📁 .docker/.env.ci (1 error)
📁 assets/.gitkeep (1 error)
📁 .editorconfig (1 error)
📁 wp-env/setup/.htaccess (1 error)
📁 .wp-env.json (1 error)
📁 src/Logger/.gitkeep (1 error)
📁 phpstan.neon.dist (1 error)
📁 bin/build-docker.sh (1 error)
📁 bin/_lib.sh (1 error)
📁 bin/sync-package-version.sh (1 error)
📁 bin/run-codeception.sh (1 error)
📁 bin/install-plugins.sh (1 error)
📁 bin/install-test-env.sh (1 error)
📁 bin/local/run-e2e-tests.sh (1 error)
📁 bin/local/setup-docker-env.sh (1 error)
📁 bin/local/run-qa.sh (1 error)
📁 bin/local/run-unit-tests.sh (1 error)
📁 .docker/init-docker.sh (1 error)
📁 examples/wpgraphql-logging-nextjs/example-app/src/pages/[slug].js (1 error)
📁 wpgraphql-logging.php (2 errors)
📁 src/Admin/View/Download/DownloadLogService.php (1 error)
📁 readme.txt (2 errors)
📁 activation.php (1 error)
📁 deactivation.php (1 error)
📁 src/Admin/View/Templates/WPGraphQLLoggerView.php (1 error)
📁 src/Admin/View/Templates/WPGraphQLLoggerNotice.php (1 error)
📁 src/Admin/View/List/ListTable.php (1 error)
📁 src/Admin/Settings/Templates/admin.php (1 error)
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Psalm 6.20.1 (#833, #834) added errors that now fail code quality on
mainand on every PR that touches these plugins (for example #837 and #838).MissingOverrideAttributeerrors. Suppressed the same waywpgraphql-logging/psalm.xmlalready does.PossiblyInvalidArgumenterrors onregister_activation_hook/register_deactivation_hook. WordPress passes$network_wideto these callbacks, and PHP ignores the extra argument, so the code is fine. Added the two files to the existing suppression, the same wayhwp-previews/psalm.xmlhandleshwp-previews.php.Verified locally:
composer run-script php:psalmandcheck-cspass for both plugins.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with diagnosing the CI failures and writing the Psalm config changes.