Repository navigation
Conversation
|
@Peolite1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
The live workflow is a good step, but three rejected-path checks only warn when they fail. Duplicate registration, missing-name resolution, and invalid scheme regressions would still leave the job green. Please make every required rejected path fail the smoke job. |
|
The rejected paths fail correctly now. The new chaos workflow still fails the supply-chain gate. Use a fixed runner image, pin checkout, rust-toolchain, and upload-artifact to full SHAs, and give cargo install an exact version. Match the existing pinned workflow conventions, then rerun CI. |
check again sir |
|
The rejected checks and pins are fixed, but this job can still hide failures. |
done |
|
The workflow now fails correctly, but the live smoke test only checks the registry NotRegistered path. Please register a meta-address, read it back, then test a rejected registry call so both paths are covered. |
Replace the Futurenet job with a real deployed-network smoke test**
Closes #185
Summary
The original
.github/workflows/integration-futurenet.ymljob ran the in-process Soroban integration suite (the chaos tests) withcontinue-on-error: true. It did not adequately prove that the compiled and deployed contracts correctly operated over an authentic Futurenet RPC.This PR addresses this by separating out the local integration tests into their own independent workflow, and repurposing the Futurenet CI job to run a complete deployment and smoke test against real on-chain canonical Futurenet contracts.
Changes
.github/workflows/integration-chaos.ymlso that the local in-processcargo testframework can continue operating independently with its artifact upload structure (chaos-test-results)..github/workflows/integration-futurenet.ymlto trigger thedeploy-dryrun.shscript against the live Futurenet utilizing deterministic contract deployment (via--salt).stellar/scripts/deploy-dryrun.shto not only check for the "happy paths", but properly simulate and exercise "rejected paths" across all interacting contracts, including:registerinvocation (AlreadyRegistered), andresolvecleanly rejects unknown names (NotFound).InvalidSchemeId).stealth-senderrejects attempts to re-initialize an already initialized instance (AlreadyInitialized).continue-on-error: truein the new Futurenet job so regressions in deployment or smoke-testing will hard-fail the workflow. Results output (both logs and simulated errors) from the invocation run are uploaded safely to GitHub actions artifacts for debugging regressions.