Skip to content

fix(settings): restore CTF locale corpus mapping - #142

Merged
Teakowa merged 1 commit into
mainfrom
codex/issue-141
Sep 5, 2026
Merged

fix(settings): restore CTF locale corpus mapping#142
Teakowa merged 1 commit into
mainfrom
codex/issue-141

Conversation

@e54-bot

@e54-bot e54-bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Fixes #141

Summary

  • merge reviewed data.gamemodes locale evidence into the settings mode index
  • regenerate the committed CTF settings mapping with data.gamemodes.ctf provenance
  • add generator and zh-CN settings emission/reparse regressions

Verification

  • cargo fmt --all --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace --all-targets
  • cargo run -p workshop-rs --bin workshop-catalog-gen -- check
  • independent ablation: removing the direct data.gamemodes merge makes the generator regression fail

The full corpus regeneration command remains blocked by pre-existing unrelated catalog alias collisions and settings-locale ambiguities on the current export; no unrelated fallback or semantic branch was added.

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptance evidence is incomplete: #141 requires rerunning pinned Bastion e1a0435d84f0fd1ae5192e5088e7321bcb547ab6 / src/main.opy with zh-CN against the candidate/released workshop-rs and showing the original missing setting mapping ... mode.ctf failure is gone. The PR currently verifies repo-local tests and synthetic ablation only; rerun the motivating Wright/Bastion workflow and record the result. A later unrelated compile failure is fine as long as mode.ctf is demonstrably resolved.

@e54-bot

e54-bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

Acceptance rerun for #141 (2026-09-05).\n\n- Input: pinned Bastion e1a0435d84f0fd1ae5192e5088e7321bcb547ab6, src/main.opy, locale zh-CN.\n- Released baseline: opy-provider v0.1.17 returned 1 workshop-emission diagnostic: missing setting mapping for locale 'zh-cn': 'mode.ctf'; no artifact was emitted.\n- Candidate: opy-provider built from opy-rs v0.1.17 source and linked against workshop-rs candidate 3271005.\n- Candidate result: lpp/check had 0 diagnostics; lpp/compile had 0 diagnostics and emitted workshop-rs/text-v1 (461,802 bytes), containing the localized 勇夺锦旗 entry. The serialized response contains 0 occurrences of the original missing setting mapping ... mode.ctf diagnostic.\n- The full Wright CLI wrapper remains unable to build this candidate because the pinned Wright #245 consumer still expects unrelated workshop-rs 0.1.11 variants Action::Debug/Action::Print; the direct provider run above exercises the same provider boundary and pinned Bastion workflow, and isolates the #141 mapping result.

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Teakowa
Teakowa merged commit a618bac into main Sep 5, 2026
4 checks passed
@Teakowa
Teakowa deleted the codex/issue-141 branch September 5, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore zh-CN locale mapping for the canonical CTF settings mode

2 participants