fix(settings): preserve raw Match Voice Chat semantics - #146
Conversation
Teakowa
left a comment
There was a problem hiding this comment.
crates/workshop-rs/src/settings/table.rs / tests/settings_pipeline.rs: the patch encodes matchVoiceChat -> disabled -> Disabled (and zh-CN 禁用) as a stable contract, but the reviewed locale corpus only links enableMatchVoiceChat directly to Enabled; its Disabled provenance is from unrelated settings. #144 explicitly requires the disabled state to be independently evidenced rather than inferred by symmetry. The new round-trip test exercises the mapping introduced by this same patch, so it does not supply independent evidence. Please add provenance-linked Workshop/upstream evidence that enableMatchVoiceChat: false uses raw Match Voice Chat: Disabled / 比赛语音聊天: 禁用, or do not encode that false-state mapping yet.
Summary
lobby.enableMatchVoiceChatboolean setting.Enabledraw Workshop value family, including启用in zh-CN.Validation
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace --all-targets— 287 passedcargo run --locked -p workshop-rs --bin workshop-catalog-gen -- checkEnabledparsing.Remaining integration evidence
The Wright provider en-US/zh-CN end-to-end workflows from #245 still need to consume a released
workshop-rsversion containing this fix before that acceptance evidence can be claimed.Refs #144