Skip to content

fix(settings): preserve raw Match Voice Chat semantics - #146

Merged
Teakowa merged 2 commits into
mainfrom
codex/issue-144
Sep 6, 2026
Merged

fix(settings): preserve raw Match Voice Chat semantics#146
Teakowa merged 2 commits into
mainfrom
codex/issue-144

Conversation

@e54-bot

@e54-bot e54-bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Reconcile Match Voice Chat onto the canonical lobby.enableMatchVoiceChat boolean setting.
  • Preserve the reviewed Enabled raw Workshop value family, including 启用 in zh-CN.
  • Reject the unevidenced false/Disabled state explicitly instead of inferring a mapping.
  • Add projection reconciliation, census support, and en-US/zh-CN parser-emitter regressions.

Validation

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace --all-targets — 287 passed
  • cargo run --locked -p workshop-rs --bin workshop-catalog-gen -- check
  • Independent generic-Bool ablation makes the enabled regression fail at Enabled parsing.

Remaining integration evidence

The Wright provider en-US/zh-CN end-to-end workflows from #245 still need to consume a released workshop-rs version containing this fix before that acceptance evidence can be claimed.

Refs #144

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crates/workshop-rs/src/settings/table.rs / tests/settings_pipeline.rs: the patch encodes matchVoiceChat -> disabled -> Disabled (and zh-CN 禁用) as a stable contract, but the reviewed locale corpus only links enableMatchVoiceChat directly to Enabled; its Disabled provenance is from unrelated settings. #144 explicitly requires the disabled state to be independently evidenced rather than inferred by symmetry. The new round-trip test exercises the mapping introduced by this same patch, so it does not supply independent evidence. Please add provenance-linked Workshop/upstream evidence that enableMatchVoiceChat: false uses raw Match Voice Chat: Disabled / 比赛语音聊天: 禁用, or do not encode that false-state mapping yet.

@Teakowa
Teakowa merged commit 41cb28f into main Sep 6, 2026
4 checks passed
@Teakowa
Teakowa deleted the codex/issue-144 branch September 6, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants