Skip to content

fix(deps): consume workshop-rs 0.1.18 - #260

Merged
Teakowa merged 2 commits into
mainfrom
codex/issue-259-workshop-018
Sep 5, 2026
Merged

fix(deps): consume workshop-rs 0.1.18#260
Teakowa merged 2 commits into
mainfrom
codex/issue-259-workshop-018

Conversation

@e54-bot

@e54-bot e54-bot commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Synchronize Wright on exact workshop-rs and opy-rs 0.1.18 with deltin-rs 0.1.2.
  • Remove the obsolete opy-compiler dependency and adapt the released owner APIs.
  • Lower debug and print through canonical createHudText calls and preserve analyzer/provenance behavior.
  • Refresh contract-sensitive fixtures and remove stale dedicated-action boundary entries.

Validation

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo test --workspace --all-targets --all-features (green; two external-corpus tests remain ignored)
  • Native OPY fixture compile succeeds with 6,715 output bytes and Create HUD Text output.
  • Ablating deltin-rs 0.1.2 back to 0.1.1 reproduces the workshop-rs 0.1.11 versus 0.1.18 resolver conflict.

Pinned real-project workflows

Using the released opy-provider v0.1.18 and the requested entry paths, all three workflows reached Wright with source provenance provider-artifact and no fallback. The remaining settings parser diagnostics are: Bastion zh-CN and en-US, expected a settings string at line 3; Overwatch-AI-PVE zh-CN, expected a settings number at line 34. These are retained as owner-side settings contract evidence rather than masked in Wright.

Fixes #259

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crates/wright-analyzer/src/analysis.rs — the createHudText branches in visit_action_value_roots / visit_values_in_action match every canonical HUD-text call, not just the synthetic Debug / Print calls introduced here. Native/provider createHudText actions therefore stop traversing their other arguments, so expensive-loop-check and repeated-value analysis can miss expressions they previously analyzed. Restrict this special path to the synthetic calls (the lowering already carries the wright:Debug / wright:Print marker) and keep normal createHudText calls on full-argument traversal.

@Teakowa
Teakowa merged commit 64b8877 into main Sep 5, 2026
15 of 17 checks passed
@Teakowa
Teakowa deleted the codex/issue-259-workshop-018 branch September 5, 2026 16:21
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Make Workshop Great Again Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Synchronize Wright's Workshop dependency graph on workshop-rs 0.1.18

2 participants