Fail closed when primary VF lookup is Err or missing - #121
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Fail closed when primary VF lookup is Err or missing#121Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
cursor
Bot
force-pushed
the
cursor/vf-primary-miss-fail-closed-1c99
branch
from
September 7, 2026 04:14
1e33e66 to
3644090
Compare
Pitchfork-and-Torch
marked this pull request as ready for review
September 7, 2026 04:20
This was referenced Sep 7, 2026
Closed
VF Err and a missing result key were collapsed to visibility_reason None. Hydrator Err is skipped by update_all, so VFFilter treated both as Allow. Stamp UnspecifiedReason so the filter drops, matching XaiVfClient missing ids. Successful Ok(None) Allow is unchanged. Rebased onto xai-org/x-algorithm main. Keep upstream's combined result map and in_network_ids dedup. Following hydrator uses the same resolve path.
Pitchfork-and-Torch
force-pushed
the
cursor/vf-primary-miss-fail-closed-1c99
branch
from
September 8, 2026 23:13
3644090 to
902a06f
Compare
Author
|
Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class. |
Author
|
Reopened. This was a serving-path hunt PR parked by mistake during the 2026-09-08 intern-stack cleanup. Not a reject of the class. Leaving it for xAI review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
VFCandidateHydratorturns a primary VFError a missing result key intovisibility_reason = None.VFFilterkeepsNone.Some(Err)used to return hydratorErr.Hydrator::update_allskips that write, so the candidate keeps the defaultNoneand still serves. A missing map key was written asNonedirectly.Ok(None)is a successful Allow. That path is unchanged.This is not #119 (retweet primary looked up by wrapper id). This is not #117 (QuoteHydrator TES / socialgraph). This is not label or TES-flag miss work.
VFCandidateHydrator::resolve_visibility(Following uses the same function)VFFilter::should_drop(None => false)XaiVfClient::results_to_mapalready writesUnspecifiedReasonfor a missing response id. The hydrator was throwing that away onErrand on Strato keys that never come back.Fix
Stamp
FilteredReason::UnspecifiedReasonon primaryErrand missing key soupdate_allwrites it andVFFilterdrops (Some(_) => true). Same sentinel the Xai VF client already uses.Ancillary
Err/ missing key now setdrop_ancillary_postsso a quote, reply, or retweet whose child was not evaluated is also dropped. Successful ancillary Allow (Ok(None)) is unchanged. Interstitial on a child is still not treated as Drop (leftover).Tests
ErrstampsUnspecifiedReason(no longer hydratorErr)UnspecifiedReasonOk(None)staysNone(Allow)Err/ missing key drop; ancillary Allow does notVFFilterdropsUnspecifiedReasonand still keepsNoneStandalone decision-table harness (same match arms): 12 assertions passed.
cargo testcannot run. Public dump has no Home Mixer manifest.Leftover
Quote / retweet / ancestor
Action::Interstitialstill does not setdrop_ancillary_posts. Wrapper can survive a soft verdict on the child. Separate from lookup miss.