chore(ranking_scorer): add negative weight assertions and clarify quote-tweet boost eligibility - #198
Open
SB2318 wants to merge 1 commit into
Open
chore(ranking_scorer): add negative weight assertions and clarify quote-tweet boost eligibility#198SB2318 wants to merge 1 commit into
SB2318 wants to merge 1 commit into
Conversation
…ote tweet boost eligibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #196
Thank you for open-sourcing the repository! While reviewing
ranking_scorer.rsandparam.rs, I have analyzed five feedback items regarding parameter configurations and scoring logic:param.rsTruncation Check: Verified thatparam.rsis fully closed and intact through line 1173 (PhoenixScoresResultSize).pdwellKey Mapping: Confirmed that mapping"pdwell"topost_unexploredinapplied_weights_mapis intentional and consistent with side-effect scoring maps across the pipeline.debug_assert!check inrecompute_sums()to guarantee negative action weights (NotInterestedWeight,BlockAuthorWeight, etc.) remain non-positive magnitudes to prevent sign inversion misconfigurations.ShadowTrafficPhoenixClusterRatesTyping: ConfirmedVec<String>is required to encode"ClusterName:Rate"key-value pairs for per-cluster rate overrides.bidirectional_boost_eligible()clarifying that quote-tweets are intentionally eligible because they contain new original commentary authored by the mutual-follow user.Changes Made
home-mixer/scorers/ranking_scorer.rs:recompute_sums().bidirectional_boost_eligible()for quote-tweet handling.Checklist