Skip to content

Give list items past the end of the expected pairs the item before's type - #446

Merged
Rigidity merged 1 commit into
rigidity/inference-restructure-13e6from
rigidity/inference-restructure-13e7
Nov 19, 2026
Merged

Rigidity merged 1 commit into
rigidity/inference-restructure-13e6from
rigidity/inference-restructure-13e7

Conversation

@Rigidity

@Rigidity Rigidity commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Part of #362 (step 13e, layer 7 of 9).

An item of a list literal past the end of the pairs its expected type has gets the type the item before it was expected to be, if the remaining expected type ends in nil. The expected type is often another list literal's inferred type, which only has as many items as that literal, such as (2, nil) for [2], and that's what the type would be as a List. So first(([2], [3, make()])) compiles, with make() as 2; on main, only first::<List<Int>> compiled.

  • Calls with arguments infer for themselves. A call with arguments past the end still infers its generics from them: optional(nil) there is nil. Both cases pin their inferred types through a binding.
  • Final expected types. A list expected to be a type of its own that ends there can't be longer anyway, so this only matters where the list's expected type is a hint.
  • Not a list end. An expected type that goes on as something other than nil, such as (Int, Any), isn't the end of a list. [1, make()] there still can't infer make, as on main, and that's pinned in generic_inference_element_bounds_errors.

The stack (#362 step 13e, layers 6–9)

These layers close the gaps that the merged 13e layers (#438–#442) left, so the generics campaign ends with no follow-ups. Each layer is its own PR:
6. An argument's expected type counts when it's what the call's solution has to be: wrap(map(fn(x) => x, 5)) with (5, Int) expected.
7. List items past the end of the expected pairs: first(([2], [3, make()])).
8. Struct fields and inner pairs keep a lambda parameter's generic references.
9. A lambda's shared or caller generics are instantiated when its body captures none of their values: the soundness limits that 13e pinned.

Fuzzer, per layer. infer-fuzz --compare against baselines from main 6aea07a5, on all four configurations (generators 1 and 2, seeds 0..4000 and 4000..8000). Every layer has 0 regressions and 0 unsound variants, changes no variant that main infers, and leaks no {generic N}. Newly inferred variants, cumulative: 37 (6), 40 (7), 40 (8), 143 (9). The top PR has the full table.

Breaking changes. None. No program that compiles on main changes its type, CLVM output or diagnostics. Pinned errors that now compile get the type that explicit instantiation gives, and each is a test.

Review. Three rounds:

  • Round 1 (three reviewers):
    • Three conditions in layer 6 had no test. Two are pinned now, and the third, that no later argument writes the generic, is dropped, since it only rejected sound programs.
    • Layer 7 also fired where the expected type goes on as Any; it's limited to a real list end now.
    • Layer 9's alternative solve lost the instantiation of a lambda before its value, which is fixed.
  • Round 2 (three reviewers): a blocker in layer 9. In a recursive call the lambda body could name the caller's T (x as T), so a value escaped with the wrong type. It's fixed, and pinned in names_the_callers_generic.
  • Round 3 (two reviewers): correctness found nothing. A test gap for the per-lambda cache is filled by one_of_two_lambdas_captures.

Mutant rule. Every mutant ran in a scratch worktree, under timeout 120, after a separate build step.

Note

Medium Risk
This changes which types are inferred for calls with lambda arguments, list literals and field accesses, all in the compiler's call inference. A mistake would reject valid programs or accept unsound ones. The risk is limited by these points:

  • Every new solution is checked against the call before it's used.
  • Three review rounds probed soundness, and their one unsound case is pinned as an error.
  • A per-layer fuzzer comparison shows 0 regressions and 0 unsound variants.

Changes by area:

  • call_inference.rs: the hint rule for an argument's expected type; which lambda parameters are instantiated (generic_parameter_types, names_restored_generics); instantiation in the alternative solve.
  • lambda.rs: LambdaParameter and LambdaBody::captures_generics.
  • list.rs: items past the end of the expected pairs.
  • field.rs: wrapped_at and keeps_reference.
  • compiler.rs: ArgumentFrame::lambda_parameters holds LambdaParameters.
  • rue-hir/database.rs: next_hir_id, hirs_between and symbol_count.
  • tests/types/generic_inference_*: new tests and moved pins.

…type

An item of a list literal past the end of the pairs its expected type has, where that type ends in
`nil`, gets the type the item before it was expected to be: the expected type is often another list
literal's inferred type, which only has as many items as that literal, such as `(2, nil)` for
`[2]`, and that's what the type would be as a `List`. So `first(([2], [3, make()]))` compiles, with
`make()` as `2`, where only `first::<List<Int>>` did. A list expected to be a type of its own that
ends there can't be longer anyway, so this only matters for lists whose expected type is a hint,
and a call with arguments there still infers its generics from them. An expected type that goes on
as something other than `nil`, such as `(Int, Any)`, isn't the end of a list, and is left as it
was.
@Rigidity
Rigidity added this pull request to stack #449 November 19, 2026 08:31
@Rigidity
Rigidity merged commit 9956bdc into main Nov 19, 2026
6 checks passed
@Rigidity
Rigidity deleted the rigidity/inference-restructure-13e7 branch November 19, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant