Repository navigation
Add dev build skills, and keep the Default Fee input a fixed width - #1029
Merged
Merged
Conversation
… own Both run pnpm tauri:dev detached, watch its log while the user tests, keep it running through edits so it rebuilds, and report what was notable when the app closes. The fresh-wallet skill gives the build a new SAGE_ROOT; the other unsets SAGE_ROOT and first checks that the installed Sage isn't running and that the user accepts any database migrations the release doesn't have.
Beside a long description, the input shrank, most of all as a fixed amount, which fell to about 100px in an 800px window. It's now 256px in every mode, like the other settings controls with fixed widths.
- Check database migrations in both directions before launching on real wallets, since any migration error leads to Sage's delete-and-resync dialog, and read applied versions in a way that works on WAL databases - Say what the installed release does with a database migrated past it, and that a dev build's WalletConnect sessions and frontend settings are its own - Keep fresh roots temporary and reusable within a session, with a given path to keep one longer - Only count the window as up when sage-tauri runs, name the usual sources of log floods, and install with the pinned pnpm and the frozen lockfile
- Check every applied migration's checksum and success flag, not just the highest version, since a changed or failed migration brings up the same reset dialog - Move the check into a script that opens databases read-only and doesn't create a missing one - Fix the wording of which Running line means the window is up
- Block a launch only on databases it opens (the active wallet's, the shared ones and the apps database), and warn about other wallets, noting when the installed release already fails on them too - Handle release tags without the apps migrations, and missing tags - Report unreadable databases without blocking, and count an empty or missing database as having nothing applied
The migration check treated every database of the active wallet, and every shared database, as opened at launch, but Sage opens only the active wallet's database and shared database on its network. Others are now reported as what would happen if they were opened, without blocking or asking. The active wallet's databases are listed even before they exist, and shared databases aren't compared with releases that don't have them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two agent skills for trying a dev build by hand, and fixes the Default Fee setting's input, which shrank beside its description.
Dev build skills
/dev-fresh-walletsrunspnpm tauri:devwith a newSAGE_ROOTin the agent's scratchpad, so testing starts with no wallets and default settings. A previous root can be reused ("same wallets as last time")./dev-my-walletsruns it withSAGE_ROOTunset, against the real data directory: the real keys, wallet databases andconfig.toml. Webview storage (frontend settings, WalletConnect sessions) is per origin, so the dev build has its own. Before launching it checks that the installed Sage isn't running, and runsscripts/check_migrations.py._sqlx_migrationsread-only (version, success and SHA-384 checksum) and compares it with the checkout's migrations and with the installed release tag's.Both share
.claude/skills/dev-fresh-wallets/references/dev-session.md:Default Fee input
FeeAmountInputtakes awrapperClassNamefor this, since in automatic modeclassNameonly sets the height.Decisions to confirm
~/sage-profiles/.Checked in the sandbox at 1280, 800, 660 and 390px wide: the control stays 256px in all three modes, the below-minimum warning wraps within it, and the page doesn't scroll sideways. The catalogs aren't updated here, so the next release needs
pnpm extractfor the new description.Note
Low Risk
The app change is a width and a description on one settings row, through a new optional prop that no other fee input passes. The skills only add agent instructions and a read-only script under
.claude/, and don't affect the app.wrapperClassNameonFeeAmountInputandclassNameonAutoFeeInputdev-fresh-wallets,dev-my-wallets(with a read-only migration check script) and their shared session reference