Added: a real matmul function and vector matrix mul assmebly for xs3 - #222
Merged
Merged
Conversation
xalbertoisorna
self-requested a review
September 1, 2026 09:19
LeslieXMOS
marked this pull request as draft
September 1, 2026 09:48
LeslieXMOS
marked this pull request as ready for review
September 3, 2026 05:31
xalbertoisorna
requested changes
Sep 3, 2026
xalbertoisorna
left a comment
xalbertoisorna
left a comment
Contributor
There was a problem hiding this comment.
In general it is good progress, I requested some changes
Co-authored-by: xalbertoisorna <124703429+xalbertoisorna@users.noreply.github.com>
Co-authored-by: xalbertoisorna <124703429+xalbertoisorna@users.noreply.github.com>
xalbertoisorna
approved these changes
Sep 14, 2026
xalbertoisorna
left a comment
xalbertoisorna
left a comment
Contributor
There was a problem hiding this comment.
Looks good! fits well with the rest of layers and thanks for adding test as well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a real matmul function and vector matrix multiplication assembly with XS3 VPU