Repository navigation
Conversation
Owner
Author
|
Opened upstream PR: pingdotgg#40286 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
T3 Code currently has no Arabic UI, and its layouts across web and mobile rely on physical left/right utilities and positioning that break under right-to-left (
dir="rtl") directionality. Arabic-speaking users fall back to English on web, mobile, and desktop.Change
Adds full Arabic (
ar, «العربية») localization and RTL layout support across web, mobile, desktop, and shared contracts:packages/client-runtime,apps/{web,mobile,desktop}):ar(«العربية») inpackages/client-runtime/src/locales.ts, all threegt.config.jsonfiles, desktop/mobile catalog loaders, and Hermes@formatjs/intl-pluralrulesarlocale data."arabic العربية"as a separate plain search term on the web Language settings row (settingsSearch.ts) so the existing Englishmsg()key hash stays untouched across every catalog (same as feat(i18n): add Ukrainian pingdotgg/t3code#38600 / feat(i18n): add Turkish pingdotgg/t3code#38681).document.documentElement.dir = localeDirection(locale)and Base UI<DirectionProvider>on web, and RTL layout direction on mobile.packages/contractsviamsg()/errorMessage()so client error surfaces translate consistently.apps/{web,mobile,desktop}/src/i18n/translations/ar.json):en.json: web (10,244 keys), mobile (5,189), desktop (125) — 13,169 unique strings total.zero,one,two,few,many,other), preserves every{placeholder}, ICUselectkey, and<T>JSX tree shape, and keeps product/provider names, model IDs, commands, paths, and code identifiers in English.apps/web,apps/mobile):left/right/ml/mr/pl/pr/text-left/text-right) to logical CSS equivalents (start/end/ms/me/ps/pe/text-start/text-end/inset-inline-*) and mirrors directional icons (rtl:-scale-x-100).+N -M), and theT3 Codewordmark indir="ltr"so technical content stays readable inside RTL UI.Scope
This adds a new locale (
ar) along with the RTL layout support required for Arabic to render cleanly, so it is a feature rather than a bug fix and I am not a vouched contributor. Opened the same way as the other community locale PRs (pingdotgg#34720, pingdotgg#38118, pingdotgg#38600, pingdotgg#38681, pingdotgg#39600). I searched open and closed PRs and issues for Arabic and found no Arabic translation PR (only pingdotgg#27019 for inline RTL text direction in specific inputs).apps/marketingis left out of scope for now. Happy to adjust scope or move to a discussion if a maintainer prefers.Verification
Verified locally on Windows 11 (Node 26.13.1):
ar.jsonagainsten.json— 0 missing keys, 0 extra keys, 0 ICU/placeholder/rich-text structure errors.vp run check:changedpassedunused patches,format(all changed files),lint(0 warnings, 0 errors),knip(knip:check:files&knip:check:exports),typecheck(42/42 packages), andreact compilercoverage (324 files).ThreadDetailsCard.browser.test.tsx,DiffPanel.browser.test.tsx) passed 17/17. Two pre-existing Windows-environment failures unrelated to this branch were seen locally (VoiceSettingsPanel.browser.test.tsxunderar-SAOS locale; one sub-pixel scroll tolerance assertion inAttachmentFilePreview.browser.test.tsx).dir="rtl",lang="ar", Replay provider): Verified live language switching without reload across Settings, Thread with approval (بانتظار الموافقة/العمل جارٍ منذ), Command palette (Ctrl+K), Diff panel, Sidebar (expanded & collapsed), Thread details card, and Snooze menu plurals. Caught and fixed 5 real RTL layout bugs during live inspection (sidebar toggle/logo overlap, top-end panel controls,ThreadDetailsCardinsetInlineEnd,+N -Mdiff counters, and diff ref combobox clipping).lint:mobile(swiftlint/ktlint/detektunavailable on Windows); macOS Electron traffic-light inset under RTL.Note
Submitted by Gemini 4 Neon (T3 Code, Antigravity harness) on behalf of Faisal (@xntsO). Translation and review council: GPT-6 Astra, Claude Opus 5.5, and Gemini 4 Neon, with final native Arabic review by Faisal.