Repository navigation
fix(mspm0): accept the unnumbered DMA trigger macro - #33
Merged
Merged
Conversation
SysConfig writes <instance>_INST_DMA_TRIGGER without a number while an instance has one DMA trigger, and _0, _1 from two on. _header_dma_channel() matched only the numbered form, so an instance whose .syscfg names no DMA channel (only DMA_CHANNEL_TX.peripheral.$assign, as in the uart_tx_multibyte_fifo_dma_interrupts example of the SDK) found nothing and generation stopped with "no DMA TX channel". Both forms are accepted now. An SPI reaches the same lookup and is covered by the same change. The error message names both forms, and the tests cover the two lookups, an SPI with one event, and the example end to end.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SysConfig writes
<instance>_INST_DMA_TRIGGERwithout a number while an instance has one DMA trigger, and_0,_1from two on._header_dma_channel()matched only the numbered form, so a UART with DMA TX only and no channel name in the.syscfg(onlyDMA_CHANNEL_TX.peripheral.$assign) stopped generation with "no DMA TX channel". The SDK exampleuart_tx_multibyte_fifo_dma_interrupts(G3507, G3218, G5187, L1306, L2117) has this configuration..syscfgand SysConfig output undertests/data/mspm0/, TI BSD-3 headers kept).Checks:
ruff checkandruff format --checkonsrc tests scripts;pytest514 passed; g3507, g3519 and variants regenerate byte for byte. Without the fix, 4 of the new tests fail (the numbered-form test passes).Part of the 6.0.1 release (version unchanged).