feat: enhance desktop download experience and clarify unnotarized beta distribution: - #299
Conversation
…a distribution: - Updated README to provide detailed instructions for sharing unnotarized beta versions of Supercode, including user guidance for macOS approval. - Modified download page to display a notice for unnotarized beta downloads, informing users of potential launch restrictions and installation steps. - Adjusted desktop download logic to identify development artifacts as unnotarized beta versions, ensuring accurate representation in the application.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe desktop download resolver now accepts ChangesDesktop beta distribution
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant DownloadResolver
participant DownloadPage
participant macOSUser
DownloadResolver->>DownloadPage: provide resolved beta metadata
DownloadPage->>macOSUser: show beta warning and download link
DownloadPage->>macOSUser: show approval and DMG eject instructions
Merge Risk: ⚪ Minimal · up to The beta download flow identifies unnotarized development builds and presents the corresponding macOS guidance without affecting standard releases. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the beta trail Comment |
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| An Apple Developer membership is not required to share the development DMG as an explicitly labeled beta. It is ad-hoc signed, not Developer ID signed or notarized. Retain the `-development.dmg` filename; do not describe it as a notarized production release. | ||
|
|
||
| Verify it with `python3 scripts/verify-dmg.py dist/Supercode-0.1.0-universal-development.dmg 0.1.0 1`, then upload the DMG and matching `.sha256` to a GitHub **prerelease** tagged `desktop-v0.1.0`. Keep it separate from the CLI latest release. Test installation and production login before announcing availability. The existing desktop tag workflow is for signed releases and requires Apple secrets; it does not automate this manual beta route. |
There was a problem hiding this comment.
The manual beta instructions use the desktop-v0.1.0 tag and say this route is separate from the signed-release workflow. However, every desktop-v* tag starts the credential-dependent production release job for the same tag. Following these instructions can therefore fail when Apple secrets are unavailable or create a competing draft production release. Use a beta tag pattern excluded from that workflow, or update the workflow to distinguish beta tags.
![tembo[bot]](https://avatars.githubusercontent.com/in/1223475?s=60&v=4){kind=small}
|
|
||
| An Apple Developer membership is not required to share the development DMG as an explicitly labeled beta. It is ad-hoc signed, not Developer ID signed or notarized. Retain the `-development.dmg` filename; do not describe it as a notarized production release. | ||
|
|
||
| Verify it with `python3 scripts/verify-dmg.py dist/Supercode-0.1.0-universal-development.dmg 0.1.0 1`, then upload the DMG and matching `.sha256` to a GitHub **prerelease** tagged `desktop-v0.1.0`. Keep it separate from the CLI latest release. Test installation and production login before announcing availability. The existing desktop tag workflow is for signed releases and requires Apple secrets; it does not automate this manual beta route. |
There was a problem hiding this comment.
Publishing the beta to a desktop-v0.1.0 prerelease tag collides with the signed production flow: .github/workflows/desktop-release.yml triggers its release job on any desktop-v* tag push (it hard-fails on the missing Apple secrets check), and its gh release create desktop-v0.1.0 --verify-tag step later expects that tag for the notarized DMG. Worth calling out here, or using a distinct tag naming for betas (e.g. desktop-beta-v0.1.0) so a manual beta doesn't kick off a failing production run or squat the production tag.
🤖 Supercode AI ReviewSummaryThis PR updates the desktop download flow to explicitly support unnotarized macOS development beta DMGs and clearly warn users during installation/launch. It adds detection logic ( Walkthrough
Changes table
Findings
Risk assessmentLow — Changes are limited to URL classification + conditional UI copy, with strict link validation and added tests to prevent accidental misclassification of non-matching artifacts. Test plan
Suggested PR descriptionWhat
Why
How tested
Automated review by Supercode · leave a 👍/👎 reaction to rate this review |
1 participant
Description
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
bun testpassesbun run typecheckpassesbun run lintpasses (if applicable)Checklist:
Summary by CodeRabbit
New Features
Documentation
Tests