Skip to content

chore: minor nit fix - #1329

Merged
asanehisa merged 1 commit into
release/1.xfrom
nit
Sep 24, 2026
Merged

asanehisa merged 1 commit into
release/1.xfrom
nit

Conversation

@asanehisa

@asanehisa asanehisa commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Missed a nit from PR #1328

@github-actions

Copy link
Copy Markdown
Contributor

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 1d95d972-8afd-471b-8163-3f194cc034aa

📥 Commits

Reviewing files that changed from the base of the PR and between 75a0b37 and 2a93d11.

📒 Files selected for processing (1)
  • packages/visual-editor/src/components/locator/LocatorWrapper.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The filter dialog in LocatorWrapper now uses Radix UI’s internal state. The component no longer declares showFilterModal or passes controlled state and modal props to Dialog.Root. The existing Dialog.Trigger opens and closes the dialog.

Merge Risk: ⚪ Minimal · up to 2a93d

The filter dialog remains opened by its trigger, and no merge-blocking behavior change is established. Merge after normal checks.

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title indicates a minor cleanup, but it does not identify the dialog state change in LocatorWrapper. Use a specific title, such as chore: use uncontrolled filter dialog state in LocatorWrapper.
Description check ❓ Inconclusive The description refers to a missed change from PR #1328, so it relates to the changeset. It does not explain the filter dialog state change. Describe the specific cleanup, including the removal of local dialog state and the use of Radix UI Dialog.Root internal state.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@asanehisa
asanehisa marked this pull request as ready for review September 23, 2026 19:03
@asanehisa
asanehisa merged commit 8bf0bc7 into release/1.x Sep 24, 2026
17 checks passed
@asanehisa
asanehisa deleted the nit branch September 24, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants