Skip to content

fix: content blocks must be used in Grids - #1331

Merged
asanehisa merged 2 commits into
release/1.xfrom
fix-grid
Sep 24, 2026
Merged

asanehisa merged 2 commits into
release/1.xfrom
fix-grid

Conversation

@asanehisa

@asanehisa asanehisa commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Existing content blocks not in Grids won't be affected but any new ones dragged in must be dragged into Grids.

Content Blocks like HoursStatus, Address, and other individual components used in Grid.

Screen.Recording.2026-09-24.at.9.26.27.AM.mov

@github-actions

Copy link
Copy Markdown
Contributor

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 27dabb7b-258c-4704-bc19-3790a4a86706

📥 Commits

Reviewing files that changed from the base of the PR and between 75a0b37 and 247c642.

⛔ Files ignored due to path filters (1)
  • packages/visual-editor/src/components/testing/screenshots/PhotoGallerySection/[desktop] version 59 with showSectionHeading false.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
📒 Files selected for processing (1)
  • packages/visual-editor/src/components/structure/MainContent.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

MainContentComponent now imports AdvancedCoreInfoCategory. The Content slot’s disallow array adds its entries except “Grid”, while preserving the existing entries.

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 247c6

New direct placements of individual content blocks into MainContent are restricted while Grid placement and existing content are preserved. No concrete merge risk is established by the remaining screenshot-only change.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: requiring content blocks to be placed inside Grids.
Description check ✅ Passed The description directly explains the Grid requirement, the behavior for existing content blocks, and relevant component examples.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@asanehisa
asanehisa marked this pull request as ready for review September 24, 2026 14:02
@benlife5

Copy link
Copy Markdown
Contributor

huh I thought we had this 🤷

@asanehisa

Copy link
Copy Markdown
Contributor Author

huh I thought we had this 🤷

Yeah I think it got weird with MainContent allowing them

@asanehisa
asanehisa merged commit 8f2bf27 into release/1.x Sep 24, 2026
18 checks passed
@asanehisa
asanehisa deleted the fix-grid branch September 24, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants