Conversation
…ntermediate transform but do transformation in one go - avoiding subtle hue shifts
BigRoy
added
the
type: enhancement
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Add focused regression tests for the new command path and inverse conversion arguments.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates transcoding to invert display/view conversions directly into target colorspaces, avoiding the scene_linear intermediate.
Changes:
- Uses a single inverse
ociodisplayoperation for colorspace targets. - Preserves display/view-to-display/view conversion behavior.
File summaries
| File | Description |
|---|---|
client/ayon_core/lib/transcoding.py |
Implements direct display/view-to-colorspace inversion. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…ew_colorspace_one_go
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Inverse display/view to colorspace without requiring
scene_linearintermediate transform but do transformation in one go - avoiding subtle hue shiftsAdditional info
This is a partial fix to https://github.com/ynput/ayon-slater/issues/30 fixing subtle color shifts on the display/view inverse. However, the effects of this should be minimal. Although, this conversion without the two-step should technically be faster too.
Testing notes:
(I believe only DCC that currently may come with a source display/view is Nuke integration)