Skip to content

Add Resolve optional pre-hook to fails if non-studio version >= 21 - #111

Merged
rdelillo merged 13 commits into
developfrom
enhancemment/flag_unsupported_resolve_free_21
Sep 21, 2026
Merged

rdelillo merged 13 commits into
developfrom
enhancemment/flag_unsupported_resolve_free_21

Conversation

@rdelillo

@rdelillo rdelillo commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Changelog Description

Resolve 21.1 removed the python integration with non-studio version, making the ayon-resolve addon incompatible:
https://www.reddit.com/r/davinciresolve/comments/1wafb08/davinci_resolve_211_release_notes/

# Notes:
We have moved the ability to script in Python to the Studio version.
The Python API was being used to hack studio features into the free version.

DaVinci Resolve relies on studio license sales to pay for the engineering team.
Unlike subscriptions, which have become normal but lock people's work up unless you pay monthly, we want to offer a differentiation from charging monthly license fees.

Changes:

  • Detect current DaVinci Resolve version and flavor from executable, raise if not supported.

Additional review information

image

Testing notes:

  1. Ensure it still works with Resolve Studio 21.1
  2. Ensure it does not work anymore with Resolve 21.1

@rdelillo rdelillo self-assigned this Sep 8, 2026
@rdelillo rdelillo added the type: bug Something isn't working label Sep 8, 2026
@rdelillo
rdelillo requested a lite review from Copilot September 8, 2026 22:31

This comment was marked as resolved.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

@BigRoy BigRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok, but not too keen honestly on the added startup time.

Comment thread client/ayon_resolve/hooks/pre_resolve_startup.py Outdated
Comment thread client/ayon_resolve/hooks/pre_resolve_startup.py Outdated

This comment was marked as resolved.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved blocking issues were identified.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Comment thread client/ayon_resolve/hooks/pre_resolve_startup.py Outdated
Comment thread client/ayon_resolve/hooks/pre_resolve_startup.py
@rdelillo rdelillo changed the title Make Resolve pre-hook fails for non-studio version >= 21 Add Resolve optional pre-hook to fails if non-studio version >= 21 Sep 17, 2026

@BigRoy BigRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version does not get detected correctly for me on Windows, this seems to be in cache:

{'mtime': 1770830676.0, 'version': '\r'}

Comment thread server/settings.py Outdated
Comment thread server/settings.py Outdated
Comment thread client/ayon_resolve/hooks/pre_resolve_check_version.py Outdated
rdelillo and others added 3 commits September 18, 2026 13:08
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@rdelillo

rdelillo commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

Version does not get detected correctly for me on Windows, this seems to be in cache:

{'mtime': 1770830676.0, 'version': '\r'}

Yeah I tried to reproduce on my machine could not find the same bug as you.
I tried Resolve 20.3 20.2 21 (studio and free) on Windows, I always end-up with the correct version returned by Resolve.exe almost immediatly. I've also tried to test with Resolve already opened still no issue on my side.

This makes me thing the capturing -v output from a subprocess is not as reliable as we we hoped.

I've changed the logic to read version from shipped ReadMe.html instead.
Not ideal but hopefully more trustable than the executable return. I retested with all of the version above, this gives me expected results. Note that the result is not cached anymore, (reading from ReadMe or a cache takes as much time).

image

@BigRoy BigRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, just come cosmetics left.

Comment thread server/settings.py Outdated
rdelillo and others added 2 commits September 21, 2026 11:35
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
@rdelillo
rdelillo merged commit 0b805bf into develop Sep 21, 2026
1 check passed
@rdelillo
rdelillo deleted the enhancemment/flag_unsupported_resolve_free_21 branch September 21, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants