Repository navigation
Conversation
Two binaries now: inlet (with `inlet admin ...`) and inletd. - Move cmd/admin into internal/admincli; expose as inlet admin subcommand - Delete cmd/admin; make build produces only inlet + inletd - Release workflow: build only two binaries, split archives (inlet / inletd), brew installs only inlet; formula updater rewrites bin.install too - Docs (README, docs.html, AGENTS.md), dev.sh, .env.example updated - Add normalizeServer/adminEndpoint/isLoopback tests - Fix pre-existing vet bug: help used Fprint with %s (now Fprintf) and was missing config.json, which TestHelpIsDetailed expects
- Rename cmd/client -> cmd/inlet, cmd/server -> cmd/inletd so go install produces inlet/inletd binaries - Add CI workflow (gofmt, vet, test -race) on PRs - Make release.yml runnable via workflow_dispatch (upload/tap bump skipped) - Require --server for inlet admin auth (no implicit demo default) - Stop render goroutine before restoring the screen; add missing return in case auth - Credential-separation tests (temp HOME): admin ignores config.json, client commands ignore admin.json - Harden formula: rewrite test do if it references removed binaries - README: go install paths + localhost default note; retitle local admin heading; drop migration note (no existing clients)
ynui
changed the title
inlet admin (Option A)inlet admin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Option A from the CLI-shipping discussion: two binaries instead of three. The
remote admin commands move into the client as
inlet admin ..., so a singlebrew install ynui/tap/inletgets the client and the operator commands, whileinletdstays a separate server artifact (Docker / release archive /go install).cmd/admin→internal/admincli; client dispatchescase "admin".cmd/admin;make buildnow produces only./inletand./inletd.inlet-…andinletd-…, checksum both, uploadinlet*-$VERSION-*,formula installs only
inlet(tap updater also rewritesbin.install).docs.html,AGENTS.md),scripts/dev.sh,.env.exampleupdated to
inlet admin.docs.htmlno longer claims brew ships the server.normalizeServer/adminEndpoint/isLoopbacktests.Fprintwith%s, which printed aliteral
%sand was missingconfig.json(expected byTestHelpIsDetailed).Test plan
gofmt -l cmd internalcleango vet ./...cleango test -race ./...all passmake buildproducesinlet+inletdonly./inlet admin version/./inlet admin --helpinletd token create→inlet admin auth→inlet admin token list/config showNotes
inletdhas no brew formula by design (Docker-first). It ships as its ownarchive and via
go install github.com/ynui/inlet/cmd/server@latest.bin.installautomatically).