Repository navigation
fix(bench): snapshot TCMalloc Bazel dependency lock - #608
Merged
Merged
Conversation
Local-Gate: v1 tree=c4bc71cbbaa5a46afe781a70c76a417ea85caf4d secs=63 lanes=lint:run
Ci-Attestation: {"at":1792518151,"gate":"python/all/lint","host":"linux-x86_64","key":"b86f503eab4eed99b56975e9af802be111a585dcbe641a8b69fa2c9d874df4f6","lane":"lint","parents":["859dd1ce0781221ba9a8b1cee77ab984013e084d"],"secs":63,"stamp":"7e9da830f63c770edf531ec18c76cb39","tree":"c4bc71cbbaa5a46afe781a70c76a417ea85caf4d","v":1,"via":"run"}
Local-Gate: v1 tree=4e16c03aa1b0da3c9f099604e5eb37d143ae566f secs=57 lanes=lint:run
Ci-Attestation: {"at":1792518225,"gate":"python/all/lint","host":"linux-x86_64","key":"1950e59001fa40c6f7086bfc2cfb4c8afe3197c48cf7a46a5a9177c2f262884e","lane":"lint","parents":["b43d74e64985c8b9f40c5e5105def8b97e2e3f3d"],"secs":57,"stamp":"283bac62b0a8bf5b693c2888299bba12","tree":"4e16c03aa1b0da3c9f099604e5eb37d143ae566f","v":1,"via":"run"}
zackees
force-pushed
the
fix/benchmark-tcmalloc-lock
branch
from
October 20, 2026 17:44
e2ec47e to
db1df11
Compare
This was referenced Oct 20, 2026
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled benchmark failed because regenerating TCMalloc’s dependency lock no longer matched its pinned hash. The runner also moved to Bazel 9.3.0, which the old minimum-version check accepted despite a different lock format.
Supply the resolved lock and
.bazelversionas a checksummed source patch, require exactly Bazel 9.1.0 from that source directory, and run query/build with--lockfile_mode=error. Print the native build log on failure so Actions exposes the underlying error.Validation: all 45 local gate checks passed; ten allocator builder tests include rejection of corrupt locks and newer Bazel versions before command execution; builder selftest; fresh archive/patch verification; Bazel 9.1.0 query and static-library build with an unchanged lock hash. Hosted native libraries and smoke workload passed. The smoke workflow then reached its existing publication-only validator, which rejects reduced smoke data. Full-mode verification passed on the exact pushed SHA
db1df119955acd0af08bcbc392dff9fa8ff6d4b9: https://github.com/zackees/mimalloc-pprof/actions/runs/39470369405. This includes the full benchmark workload, raw-run validation, site rendering/validation, and independent artifact audit. All 32 PR checks passed.Fixes https://github.com/zackees/mimalloc-pprof/actions/runs/38542710076.