Repository navigation
fastcgi: do not pass client Proxy header as HTTP_PROXY - #4367
Open
Ramya-9353 wants to merge 1 commit into
Open
Ramya-9353 wants to merge 1 commit into
Ramya-9353 wants to merge 1 commit into
Conversation
Signed-off-by: Ramya Eliger <ramya@digiscrypt.com>
szuecs
approved these changes
Oct 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression test against master,
go test ./proxy/fastcgi -run TestFastCgiDropsProxyHeader:Expected: a client supplied
Proxyheader never reaches the FastCGI application. Actual:gofast.MapHeadermaps it toHTTP_PROXY, which PHPgetenv("HTTP_PROXY")and CGI-unaware HTTP clients read as the outbound proxy, so any client can route the application's outgoing requests through a host it controls (httpoxy, CVE-2016-5385 class).Proxyis not in the proxy's hop header list, so nothing strips it earlier.Fix: delete
HTTP_PROXYin the existing param middleware inNewRoundTripper, next to theREQUEST_SCHEMEcleanup. This matches what Go'snet/http/cgi, nginx and Apache do. The test passes with the patch;go vetandstaticcheckare clean for the package.