Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions .github/workflows/apply-blocking-store-process-locks.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
name: blocking store process locks

on:
pull_request:
paths:
- src/store.rs
- src/install_graph.rs
- src/install_graph/**
- Cargo.toml
- Cargo.lock
- .github/workflows/apply-blocking-store-process-locks.yml
push:
branches: [main]
paths:
- src/store.rs
- src/install_graph.rs
- src/install_graph/**
- Cargo.toml
- Cargo.lock
- .github/workflows/apply-blocking-store-process-locks.yml
workflow_dispatch:

permissions:
contents: read

concurrency:
group: blocking-store-process-locks-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

env:
CARGO_TERM_COLOR: always
RUST_BACKTRACE: "1"

jobs:
linux-kernel-lock:
name: Linux process-lock and recursive-cache contracts
runs-on: ubuntu-24.04
timeout-minutes: 35
steps:
- name: Check out zed-cli
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 1
persist-credentials: false
show-progress: false

- name: Install stable Rust with formatting and lint support
run: |
rustup toolchain install stable --profile minimal --component rustfmt,clippy
rustup default stable
rustc --version --verbose
cargo --version --verbose

- name: Check formatting
run: cargo fmt --all --check

- name: Prove a separate process blocks until orderly release
run: cargo test --locked --lib store::tests::install_process_lock_blocks_without_polling_until_owner_release -- --exact --nocapture

- name: Prove owner termination releases the descriptor lock
run: cargo test --locked --lib store::tests::install_process_lock_is_released_when_owner_process_is_terminated -- --exact --nocapture

- name: Run all store process-lock tests
run: cargo test --locked --lib store::tests

- name: Run recursive acquisition and cache-race tests
run: cargo test --locked --lib install_graph::tests

- name: Deny Rust warnings
run: cargo clippy --locked --all-targets -- -D warnings
6 changes: 6 additions & 0 deletions .github/workflows/recursive-install-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,9 @@ jobs:

- name: Prove failed downloads leave no cache publication
run: cargo test --locked --manifest-path zed-cli/Cargo.toml --lib install_graph::tests::failed_downloads_remove_staging_files_and_never_publish_cache_entries -- --exact --nocapture

- name: Prove the lower-level store lock blocks across processes
run: cargo test --locked --manifest-path zed-cli/Cargo.toml --lib store::tests::install_process_lock_blocks_without_polling_until_owner_release -- --exact --nocapture

- name: Prove owner termination releases the lower-level store lock
run: cargo test --locked --manifest-path zed-cli/Cargo.toml --lib store::tests::install_process_lock_is_released_when_owner_process_is_terminated -- --exact --nocapture
Loading
Loading