Repository navigation
feat(DEN-2278): adopt shared zed inspect schema v1 - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adapts the merged VS Code foundation to the shared inspect v1 contract under review in
zed-pkg/zed-cli#235/ issuezed-pkg/zed-cli#191.zed inspect --format json --root <absolute-path>;schema_version1.x reports only;implementation=zed-pkg,command=inspect,offline=true,mutates_project=false, andloads_credentials=false;diagnosticsinto the existing extension issue model;zed-commandargv/cwd recommendations into the centrally confirmation-gated action model;zedexecutables, incomplete action safety metadata, and action working directories outside the canonical inspected workspace;mutatesProject,requiresNetwork, andexecutesPackageCoderisk metadata in output, Quick Pick, and the modal confirmation;Safety
This PR does not make the extension a solver and does not weaken its execution boundary. CLI recommendations still cannot execute without the extension's modal confirmation. Child processes continue to use argv-only
spawn(..., { shell: false }), bounded timeouts, and output redaction.Tests
Adds coverage for the new argv, safe v1 diagnostic/action normalization, root binding, unsafe safety declarations, non-
zedexecutable rejection, out-of-workspace cwd rejection, action-risk preservation, and fallback non-mutation.Tracking
zed-pkg/zed-cli#235, current exact head70fd364c5cf592e2ba03aed3670b4c1601c0836czed-pkg-test/zed-pkg-e2e#119zed-pkg-test/zed-pkg-e2e#125, pinned to this VS Code head05835dbea0c081c7128d98a219d7731fbd20d941Draft until the shared CLI v1 head is promoted and this exact VS Code head is green in repository CI plus the independent real-binary interop lane.