Repository navigation
Map fits the screen; dividers, active states and lifetime rows corrected - #5
Merged
Merged
Conversation
Map: restores the centred period control (the title row pushed it 72px off centre) and fixes the height. The sum missed the insets <body> adds and used --nav-h, a reserve 28px taller than the tab bar, so the page scrolled under a panning thumb with a home bar and stopped short of the bar without one. The layout now measures the bar (--nav-real); the map ends at its edge, the page is exactly one screen in every case (measured with emulated insets on 393x852 and 375x667), and document scroll is pinned while the map is up. Plan: the calendar sits directly left of + New on both halves (page tools go further left), so both land in the same spot when switching. Header and tabs: the gear is accent-coloured on Settings, its sub-pages and Reconcile, like an active tab; Plan stays lit on the calendar and Activity on the statement. Rules: .hairline draws a row's bottom edge, but Security Log, API permissions and Reconcile's scan list applied it to every row but the *first*, missing the rule between rows one and two and adding one after the last. The member sheet's Allowance row kept its rule when nothing follows it (your own sheet). "Security Log" capitalised. Safe to Spend: Harmony's sparkle takes the accent, as everywhere else Harmony speaks, while the narration keeps its tone; Income's figure is green. Lifetime: Earned | Approved, Saved | Refunded, Denied | Cancelled | Let go. The widest figures get half a row; the three that never left share one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019iNojndGyPD9Kt2Db6gCCf
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4, fixing what that round got wrong on a phone and a few things found along the way. Each change was checked in Chromium with phone viewports (393×852 and 375×667, touch,
isMobile) and an emulated home-bar safe-area inset, and screenshotted in light and dark.Map
<body>adds, and used--nav-h, a reserve 28px taller than the real tab bar. The result: with a home bar the page scrolled 34px under a panning thumb, and without one the map stopped 28px short of the bar.--nav-real, alongside the existing--header-h), so the map ends at the bar's edge and the page is exactly one screen tall in every case.scrollYstaying at 0.Plan header
The calendar now sits directly left of + New on both Recurring and Buckets, so both land in the same spot when switching. Measured at x=254 and x=300 on each page.
PlanHeadertakestools(placed left of the calendar) andprimarysnippets.Active states
Dividers
.hairlinedraws a row's bottom edge, but several lists applied it to every row except the first. That left the rule between rows one and two missing and added one under the last row.Safe to Spend
Lifetime (Activity)
Now Earned | Approved, then Saved | Refunded, then Denied | Cancelled | Let go. The widest figures get half a row each, and every row's figures fit their tiles in both themes.
Checks
bun run checkandbun run lintare clean.allowance,reconcileandrecurring-lifecycle, which this branch doesn't touch, and they pass when rerun on their own (28/28).🤖 Generated with Claude Code
https://claude.ai/code/session_019iNojndGyPD9Kt2Db6gCCf
Generated by Claude Code