Skip to content

Map fits the screen; dividers, active states and lifetime rows corrected - #5

Merged
zenatron merged 1 commit into
mainfrom
claude/zealous-wright-37zgm5
Oct 4, 2026
Merged

zenatron merged 1 commit into
mainfrom
claude/zealous-wright-37zgm5

Conversation

@zenatron

@zenatron zenatron commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Follow-up to #4, fixing what that round got wrong on a phone and a few things found along the way. Each change was checked in Chromium with phone viewports (393×852 and 375×667, touch, isMobile) and an emulated home-bar safe-area inset, and screenshotted in light and dark.

Map

  • Restores the centred Day/Week/Month/Year control. The title row added in Claude/zealous wright 37zgm5 #4 pushed it 72px off centre.
  • Fixes the height. The map's height formula missed the insets <body> adds, and used --nav-h, a reserve 28px taller than the real tab bar. The result: with a home bar the page scrolled 34px under a panning thumb, and without one the map stopped 28px short of the bar.
    • The layout now measures the tab bar (--nav-real, alongside the existing --header-h), so the map ends at the bar's edge and the page is exactly one screen tall in every case.
    • Document scroll is also pinned while the map is open, as a backstop.
  • Measured, with and without a home bar on both viewports: document height equals viewport height, the gap between map and tab bar is 1px (rounding), and a touch drag pans the map with scrollY staying at 0.

Plan header

The calendar now sits directly left of + New on both Recurring and Buckets, so both land in the same spot when switching. Measured at x=254 and x=300 on each page. PlanHeader takes tools (placed left of the calendar) and primary snippets.

Active states

  • The settings gear is accent-coloured on Settings, its sub-pages and Reconcile. Before, it lit only on the workspace root, and in ink.
  • The Plan tab stays lit on the Calendar, and Activity stays lit on the Statement.

Dividers

.hairline draws a row's bottom edge, but several lists applied it to every row except the first. That left the rule between rows one and two missing and added one under the last row.

  • Fixed in Security Log, the API & MCP permission list and Reconcile's scan preview.
  • The member sheet's Allowance row no longer keeps its rule when nothing follows it (your own sheet).
  • "Security Log" is now capitalised.

Safe to Spend

  • Harmony's sparkle takes the workspace accent, as it does everywhere else Harmony appears; the narration text keeps its tone colour. Verified with a teal accent.
  • The Income figure in the breakdown is green, matching the Income page, Calendar and Statement. Row labels stay ink, so the narration's tone stays the one signal on the card.

Lifetime (Activity)

Now Earned | Approved, then Saved | Refunded, then Denied | Cancelled | Let go. The widest figures get half a row each, and every row's figures fit their tiles in both themes.

Checks

  • bun run check and bun run lint are clean.
  • Unit tests: in the full run, three tests timed out at 5s under load. They are in allowance, reconcile and recurring-lifecycle, which this branch doesn't touch, and they pass when rerun on their own (28/28).
  • The Playwright e2e suite was not run.

🤖 Generated with Claude Code

https://claude.ai/code/session_019iNojndGyPD9Kt2Db6gCCf


Generated by Claude Code

Map: restores the centred period control (the title row pushed it 72px off
centre) and fixes the height. The sum missed the insets <body> adds and used
--nav-h, a reserve 28px taller than the tab bar, so the page scrolled under a
panning thumb with a home bar and stopped short of the bar without one. The
layout now measures the bar (--nav-real); the map ends at its edge, the page
is exactly one screen in every case (measured with emulated insets on 393x852
and 375x667), and document scroll is pinned while the map is up.

Plan: the calendar sits directly left of + New on both halves (page tools go
further left), so both land in the same spot when switching.

Header and tabs: the gear is accent-coloured on Settings, its sub-pages and
Reconcile, like an active tab; Plan stays lit on the calendar and Activity on
the statement.

Rules: .hairline draws a row's bottom edge, but Security Log, API permissions
and Reconcile's scan list applied it to every row but the *first*, missing
the rule between rows one and two and adding one after the last. The member
sheet's Allowance row kept its rule when nothing follows it (your own sheet).
"Security Log" capitalised.

Safe to Spend: Harmony's sparkle takes the accent, as everywhere else Harmony
speaks, while the narration keeps its tone; Income's figure is green.

Lifetime: Earned | Approved, Saved | Refunded, Denied | Cancelled | Let go.
The widest figures get half a row; the three that never left share one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019iNojndGyPD9Kt2Db6gCCf
@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0a0af14b-a1be-4f78-a492-e1c8af3ec3fb
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zenatron
zenatron merged commit f734874 into main Oct 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants