Repository navigation
Conversation
c153906 fixed the default's panel: a tab looked up before its node mounted was never looked up again, so the active tab could show bright text on no wash. It changed screens/panel/init.luau, which Zeron v2 keeps its own copy of, without bringing v2 in step, so zeron_v2_is_in_step_with_the_default fails on every pull request to zeron/zgx. v2's copy has the same plain-table lookups in its scroll-into-view effect and its overflow check. Each tab's node mounting now bumps a count those lookups follow, as in the default, and .base.json records the default's panel as it now is.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zeron_v2_is_in_step_with_the_defaultfails on every pull request tozeron/zgxsince c153906. That commit fixed the default'sscreens/panel/init.luau, a file Zeron v2 keeps its own copy of, and didn't bring v2 in step:The fix applies to v2 as well. Its copy looks tabs up in a plain table in two reactive places, the effect that scrolls the active tab into view and the check for whether the strip overflows. A lookup made before a tab's node mounted never ran again, so v2 had the same bug c153906 fixed (the active tab's wash missing). This brings over the same change: a count that each tab's node bumps when it mounts, read by a
chip_reflookup in those two places. The other reads (one later in the same effect, and Escape's focus) stay as they are, as in the default..base.jsonnow records the default's panel as it is at c153906 (3d5e0c712c4dda56). That is the only record that changes.Testing
I computed the record the way the test does (
live::hash,DefaultHasherover the file with CRLF made LF) in a small program, not withZERON_V2_BLESS. It reproduces the old record from the panel before c153906 (7fcc64426fb6411d), and all 8 files v2 overlays now match.base.json.zgx linton v2's panel gives the same 5 warnings (tokens it can't see outside the app) before and after, and no errors. I didn't build the app here, so CI runs the test itself.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.