Repository navigation
zgx: Linux title bar no longer reserves traffic-light space without window buttons - #1383
Open
katulevskiy wants to merge 1 commit into
Open
katulevskiy wants to merge 1 commit into
katulevskiy wants to merge 1 commit into
Conversation
…, not 88 On Linux and Windows, when the window reports no buttons (Hyprland and other tiling compositors draw none; full screen), the title bar fell back to the macOS traffic lights' 88, leaving an empty gap left of the sidebar toggle. It now takes the row's 10. Where no platform is said (headless, previews) the bar keeps 88, and a bar that draws its own lights (`lights = true`) never puts the toggle over them.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux without window buttons reported (Hyprland and other tiling compositors draw none, or full screen), the title bar placed the sidebar toggle 88 in, where macOS's traffic lights would be, leaving an empty gap at its left.
ds/title_bar.luautoggle_in()now:lights = true(the gallery, the title bar fixture draw their own lights): never nearer than 88, so the toggle isn't drawn over them.macOS is unchanged.
Tests
tests/full_screen_titlebar.rsoff_macos_the_controls_stay_where_they_are: was asserting the bug (88 on Linux with nothing reported); now 10, in and out of full screen. Fails on main (88), passes here.cargo test --bin zeron-zgx -- window_buttons_tests shell_tests hit_tests: 23 passed.the_controls_slide_to_the_lights_place_in_full_screen_and_backfails ("no script runs while they slide": 16 vs 0) identically on unchanged main, so it is not from this change.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.