Skip to content

fix(rpc): exit newPendingTransactions goroutine when event channel is closed #4641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
artemrootman wants to merge 2 commits into
base: develop
Choose a base branch
from
+6 −1
Open

fix(rpc): exit newPendingTransactions goroutine when event channel is closed #4641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
948354d
fix(rpc): exit newPendingTransactions goroutine when event channel is…
Sep 9, 2026
68a4b93
changelog
Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ The `zetacored` binary must be upgraded to trigger chain parameters data migrati
* [4509](https://github.com/zeta-chain/node/pull/4509) - use outbound schedule interval in sui cctx scheduling
* [4514](https://github.com/zeta-chain/node/pull/4514) - use Zeta height as a factor to calculate the EVM chain artificial height for TSS keysign
* [4513](https://github.com/zeta-chain/node/pull/4513) - use `outbound_schedule_interval` and `outbound_schedule_lookahead` in ton cctx scheduling
* [4641](https://github.com/zeta-chain/node/pull/4641) - fix busy-loop goroutine leak in `newPendingTransactions` websocket subscriptions after unsubscribe/disconnect

### Tests

Expand Down
6 changes: 5 additions & 1 deletion rpc/websockets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,11 @@ func (api *pubSubAPI) subscribePendingTransactions(wsConn *wsConn, subID rpc.ID)
errCh := sub.Err()
for {
select {
case ev := <-txsCh:
case ev, ok := <-txsCh:
if !ok {
return
}

data, ok := ev.Data.(cmttypes.EventDataTx)
if !ok {
api.logger.Debug("event data type mismatch", "type", fmt.Sprintf("%T", ev.Data))
Expand Down
Loading