fix(docs): repoint deploy at zoolutions org and bump docs-kit to 1.0.8 - #36
Merged
Merged
Conversation
Reusable-workflow `uses:` refs do not follow GitHub repo redirects, so the docs deploy broke after the mhenrixon -> zoolutions org move. - deploy-docs.yml -> zoolutions/docs-kit, image zoolutions/daisyui (image must match the repo owner for ghcr package auto-linking); same in docs/config/deploy.yml - docs-kit ~> 1.0.3 -> ~> 1.0.8 + version-aware sync (og rake template refresh); sync stamp kept below the frozen_string_literal magic comment - moved github.com/mhenrixon/* URLs in docs content -> zoolutions - CSS rebuilt; bun.lock normalizes "latest" to resolved ranges Verification: docs rspec 8 examples 0 failures; rubocop clean; actionlint clean
The docs-kit 1.0.8 sync refreshed lib/tasks/docs_kit_og.rake from the gem template, whose style (no trailing comma, path-string Rails.root.join) violates this site's stricter docs rubocop (Style/TrailingCommaInHashLiteral, Rails/FilePath EnforcedStyle: arguments) — the Docs Lint job caught it. Autocorrected via bin/rubocop -a; 344 files inspected, no offenses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same fix as pgbus#408 / docs-kit#70: reusable-workflow
uses:refs do not follow repo redirects, so the docs deploy has been failing at parse time since the org move..github/workflows/deploy-docs.yml→zoolutions/docs-kit/.github/workflows/deploy.yml@main,image: zoolutions/daisyui; sameimage:indocs/config/deploy.yml(keptregistry.username: mhenrixon— acting ghcr login, not package owner)~> 1.0.3→~> 1.0.8; ran the 1.0.7 version-awaredocs_kit:install --sync(refreshed the OG rake task template); kept the sync stamp below# frozen_string_literal: true(the generator prepends it to line 1, which disables the magic comment)github.com/mhenrixon/*URLs in docs content → zoolutions (the sync's AGENTS.md block re-stamped the old URL from the released gem's template — re-fixed here; goes away once docs-kit#70 ships in a release)bun run build:cssrebuilt;bun.locknormalizes"latest"to resolved ranges (current bun behavior)Test plan
docs/: bundle exec rspec— 8 examples, 0 failuresdocs/: bundle exec rubocop— no offensesactionlint .github/workflows/deploy-docs.ymlworkflow_dispatchDeploy docs; check the newzoolutions/daisyuighcr package visibility onceDeviations & judgment calls
Summary by cubic
Fixes broken docs deploys after the org move by repointing the reusable workflow and container image to the
zoolutionsorg and syncingdocs-kit1.0.8. Old:uses: mhenrixon/docs-kitand imagemhenrixon/daisyui(reusable workflows don’t follow redirects → parse-time failure). New:uses: zoolutions/docs-kitand imagezoolutions/daisyui, plus template sync and a RuboCop-compliant OG rake task..github/workflows/deploy-docs.ymlnow useszoolutions/docs-kit/.github/workflows/deploy.yml@mainandimage: zoolutions/daisyui; mirrored indocs/config/deploy.yml(image owner matches repo for GHCR auto-linking).docs-kitto~> 1.0.8and runs the version-aware sync; stampsdocs/config/initializers/docs_kit.rband refreshes the OG task; restyles the syncedlib/tasks/docs_kit_og.raketo pass this site's RuboCop.https://github.com/zoolutions/docs-kit; rebuilds CSS; normalizesbun.lock“latest” to ranges;Gemfile.lockincludes patch updates (e.g., Rails8.1.3→8.1.3.1).workflow_dispatchand confirmzoolutions/daisyuiGHCR package visibility.Written for commit 3f2f4bf. Summary will update on new commits.