Skip to content

chore(deploy): require dash 4.0.7 across the docs deploy path #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhenrixon merged 1 commit into from
Aug 30, 2026
Merged

chore(deploy): require dash 4.0.7 across the docs deploy path #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,10 @@ jobs:
# its docs Gemfile. `dash deploy` (not `bundle exec dash`) then works for
# every site regardless of its bundle.
- name: Install dash
# Pinned to the 4.x line: the deploy.yml this workflow deploys sets
# `minimum_version: 4.0.0` (dash-proxy identity + host migration).
run: gem install dash -v "~> 4.0"
# Floor at 4.0.7: the deploy.yml this workflow deploys sets
# `minimum_version: 4.0.7` (doctor stale-proxy recovery + registry
# credential fail-fast, on top of the 4.0 dash-proxy identity).
run: gem install dash -v "~> 4.0.7"

- name: Setup SSH agent
uses: webfactory/ssh-agent@v0.9.1
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,7 +934,7 @@ jobs:
```yaml
service: <repo>
image: zoolutions/<repo>
minimum_version: 4.0.0 # dash 4: dash-proxy identity + in-place host migration
minimum_version: 4.0.7 # dash 4.0.7: doctor stale-proxy recovery + registry credential fail-fast
retain_containers: 2
error_pages_path: public # 502/503/504.html served during a deploy gap
registry: { server: ghcr.io, username: mhenrixon, password: [DASH_REGISTRY_PASSWORD] }
Expand Down
2 changes: 1 addition & 1 deletion docs/app/views/docs/pages/deploy.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def content
plain "Every site deploys with "
a(href: "https://github.com/zoolutions/dash") { "dash" }
plain " 4 ("
code { "minimum_version: 4.0.0" }
code { "minimum_version: 4.0.7" }
plain ") and turns on the per-app dash-proxy features a docs site benefits from — no per-site tuning, the template writes them:"
end
ul do
Expand Down
2 changes: 1 addition & 1 deletion docs/config/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ image: zoolutions/docs-kit

# dash 4 renamed the on-host proxy (kamal-proxy → dash-proxy) and migrates a
# host in place; an older CLI must not deploy this config.
minimum_version: 4.0.0
minimum_version: 4.0.7

# A stateless docs site never rolls back far — keep the host tidy.
retain_containers: 2
Expand Down
2 changes: 1 addition & 1 deletion lib/docs_kit/templates/new_site.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@

# dash 4 renamed the on-host proxy (kamal-proxy → dash-proxy) and migrates a
# host in place; an older CLI must not deploy this config.
minimum_version: 4.0.0
minimum_version: 4.0.7

# A stateless docs site never rolls back far — keep the host tidy.
retain_containers: 2
Expand Down
Loading