Repository navigation
Load documentation notices from OneUptime - #126
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
godsonten
left a comment
There was a problem hiding this comment.
If the browser blocks session storage and there are two active announcements, dismissing the notice hides it at first. When the other announcement expires, the page refreshes the notice bar and shows the same dismissed notice again, without the user reloading or leaving the page. Please make sure the notice stays dismissed in this situation.
|
Resolved the blocked sessionStorage dismissal issue. The review claim was valid: timer-driven rerenders could show the same dismissed announcement again when storage was unavailable. The fix now retains the dismissed announcement ID in memory for the current page while preserving normal sessionStorage persistence. Added regression coverage for the two-active-announcement expiry scenario; all 14 notice tests pass. |
What changed
lang="en"on French pages while keeping French labels and controls.Why
This removes the need to publish the same service notice in OneUptime and deploy a matching documentation change.
Related to https://github.com/zsoftly/zcp-website/issues/91
Verification
git diff --check: passedThe repository-wide formatter still reports four unrelated existing documentation files. The full build completes browser rendering, route generation, optimized images, and AI-readable generation before the link validator reports 66 existing invalid links across 33 unrelated files.