Repository navigation
refactor(afternote): 비교 스냅샷을 카테고리별로 분리한다 (#2163) - #2164
Merged
Merged
Conversation
OnlyReadOneBook
added this pull request to stack #2165
September 25, 2026 08:53
This was referenced Sep 25, 2026
koongmai
approved these changes
Sep 26, 2026
OnlyReadOneBook
removed this pull request from stack #2165
September 27, 2026 04:55
OnlyReadOneBook
added this pull request to stack #2182
September 27, 2026 04:55
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2163
애프터노트의 수정 비교 스냅샷을 카테고리별 sealed 타입으로 분리합니다. 각 타입이 해당 카테고리의 필드만 소유하고, 서버 원본과 현재 폼을 비교할 때도 같은 타입의 필드만 다룹니다.
직접 base는 develop입니다. 부분 PATCH의 필드 생략·목록 비우기·미디어 삭제와 교체·제목 정규화·수신자 순서 의미를 유지합니다. 실제 diff는 폼 매퍼와 카테고리별 PATCH 회귀 테스트 2개 파일입니다. 곡·영상 공통 변환은 후속 #2167에서 처리합니다.
검증
HEAD
fdaa5df2f1950b8b7d222c874742cd3cbc1ad1d8에서 presentation 340개 테스트가 통과했습니다(실패·오류·건너뜀 0). presentation ktlint, 실제 base 대비 전체 diff의 모듈 소유권 검사와git diff --check를 통과했습니다.🧪 CI Test Plan
{ "androidTest": { "mode": "none", "reason": "화면·내비게이션 변경 없이 편집기 내부 값의 생성·비교 타입을 분리한다. 기존 PATCH 회귀와 카테고리별 계약을 JVM 테스트로 검증한다." } }