fix(release): repair production package validation and versioning - #433
Merged
Merged
Conversation
Four issues found auditing the production release pipeline, all stemming from the RPC bridge rewrite (1507c8c) and a --version flag that was never actually wired up: - validate-production-package.py and extractPackage.py both asserted that AppsFlyeriOSWrapper.mm contains commented-out disableAdvertisingIdentifier and waitForATTUserAuthorizationWithTimeoutInterval calls. Both APIs were removed entirely (regular and strict alike) by the RPC rewrite, so these checks could never pass again and would fail every future release. extractPackage.py's check is independent of validate-production-package.py's and runs earlier in check_packages.yml, so both needed fixing. - deploy/build_unity_package.sh and deploy/strict_mode_build_package.sh accepted --version <value> but discarded it, always emitting whatever PACKAGE_NAME string was hardcoded as the default. Every past release relied on manually re-hardcoding that string in sync with the version bump commit; the CLI flag itself was decorative. Fixed to build PACKAGE_NAME from the passed argument. - strictMode.md's doc bullet claiming the two removed APIs are strict-mode specific is now stale; updated to reflect they're gone entirely. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Kobikg78
approved these changes
Sep 17, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four issues found auditing the production release pipeline, all stemming from the RPC bridge rewrite (1507c8c) and a --version flag that was never actually wired up:
validate-production-package.py and extractPackage.py both asserted that AppsFlyeriOSWrapper.mm contains commented-out disableAdvertisingIdentifier and waitForATTUserAuthorizationWithTimeoutInterval calls. Both APIs were removed entirely (regular and strict alike) by the RPC rewrite, so these checks could never pass again and would fail every future release. extractPackage.py's check is independent of validate-production-package.py's and runs earlier in check_packages.yml, so both needed fixing.
deploy/build_unity_package.sh and deploy/strict_mode_build_package.sh accepted --version but discarded it, always emitting whatever PACKAGE_NAME string was hardcoded as the default. Every past release relied on manually re-hardcoding that string in sync with the version bump commit; the CLI flag itself was decorative. Fixed to build PACKAGE_NAME from the passed argument.
strictMode.md's doc bullet claiming the two removed APIs are strict-mode specific is now stale; updated to reflect they're gone entirely.