Skip to content

[Episode Chat] Remove the chat entry from Episode details - #6146

Merged
sztomek merged 5 commits into
mainfrom
feat/episode-chat-remove-episode-details-entry
Oct 14, 2026
Merged

sztomek merged 5 commits into
mainfrom
feat/episode-chat-remove-episode-details-entry

Conversation

@sztomek

@sztomek sztomek commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

Removes "Chat with Episode" from Episode details. The player's ⋯ menu (#6118) is now the only way into Ask about this episode, as in the P2 and Figma. This PR is based on #6141.

Removed

  • The "Chat with Episode" row above the Episode details tabs, and the chat banner in the transcript card (shown when AI summaries are off).
  • The extra tab padding that only applied when the row was shown. The tabs are back to their normal 16dp spacing.
  • EpisodeFragment.openChat(), EpisodeFragmentViewModel.episodeChatAccess() and its tests. The view model and its test are now the same as on main.
  • The podcasts module's dependency on the chat module, since nothing in podcasts uses chat any more.
  • ChatBanner and IconChat, which only Episode details used.

Kept: ChatPaywallFragment and EpisodeChatAccess, which the player still uses. Also the episode_chat string and the ic_ai icon, which the upgrade screen and transcripts use.

The flag is off in production, so this changes nothing for users.

Fixes POC-954 https://linear.app/a8c/issue/POC-954

Testing Instructions

Use a debug build with "Episode Chat" on in Beta features.

  1. Open Episode details for an episode with a transcript (Radiolab › A 4-Track Mind). ✅ There's no "Chat with Episode" row above the tabs, and the tabs keep their normal spacing.
  2. Turn off AI summaries in Beta features and open the same episode. ✅ The transcript card has no chat banner.
  3. Scroll down until the tabs stick to the top. ✅ They stick in the right place.
  4. Play the episode, open the full-screen player, then ⋯ › Ask about this episode. ✅ The chat still opens.

Screenshots or Screencast

Before After
before after

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the Event Horizon schema to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@claude

claude Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @sztomek's task in 28s —— View job


I found nothing that should block this merge. I compared the diff against origin/feat/episode-chat-analytics and nothing in the code still refers to ChatBanner, IconChat or episodeChatAccess. The podcasts module no longer refers to the chat module either, so removing that dependency is safe. The sticky tab bar position comes from onGloballyPositioned on ButtonTabs, so it adjusts itself now that the row above it is gone. The tab padding is back to a fixed 16dp in both places.

@sztomek sztomek added this to the 8.23 milestone Oct 9, 2026
@sztomek
sztomek marked this pull request as ready for review October 9, 2026 09:22
@sztomek
sztomek requested a review from a team as a code owner October 9, 2026 09:22
@sztomek
sztomek requested review from geekygecko and removed request for a team October 9, 2026 09:22
@claude

claude Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @sztomek's task in 13s —— View job


Nothing has changed since my last review: the branch is still at 6d9ce9e, and that review found nothing to fix.

@sztomek sztomek mentioned this pull request Oct 9, 2026
5 of 10 tasks
@sztomek
sztomek force-pushed the feat/episode-chat-analytics branch from e3e8b43 to c3a6d4b Compare October 9, 2026 13:33
@sztomek
sztomek force-pushed the feat/episode-chat-remove-episode-details-entry branch from 6d9ce9e to 2105326 Compare October 9, 2026 13:34
@claude

claude Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @sztomek's task in 38s —— View job


The branch was rebased to 2105326, and the changes are the same six files with the same removals as the version I reviewed before. There are no new findings, and none from earlier are still open. Every helper the removed code shared is still used elsewhere in EpisodeFragment. That covers BannerEnterTransition/BannerExitTransition (they also animate the transcript excerpt banner), episodeIconColor, Role and Arrangement.

@sztomek
sztomek force-pushed the feat/episode-chat-analytics branch from c3a6d4b to 11698c5 Compare October 9, 2026 16:08
@sztomek
sztomek force-pushed the feat/episode-chat-remove-episode-details-entry branch from 2105326 to b82b438 Compare October 9, 2026 16:08
@claude

claude Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @sztomek's task in 39s —— View job


This push has nothing new to review and no open findings. The branch is now three commits, at b82b438, and it touches the same six files with the same changes (+3/−338) as the version I reviewed before. Nothing in the code still refers to ChatBanner, IconChat, episodeChatAccess or openChat.

@sztomek sztomek mentioned this pull request Oct 9, 2026
6 of 10 tasks
@wpmobilebot wpmobilebot modified the milestones: 8.23, 8.24 Oct 12, 2026
@wpmobilebot

Copy link
Copy Markdown
Collaborator

Version 8.23 has now entered code-freeze, so the milestone of this PR has been updated to 8.24.

@sztomek
sztomek force-pushed the feat/episode-chat-analytics branch from 11698c5 to 02e2e93 Compare October 12, 2026 10:05
@sztomek
sztomek force-pushed the feat/episode-chat-remove-episode-details-entry branch from b82b438 to b71d78a Compare October 12, 2026 10:05
@claude

claude Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @sztomek's task in 15s —— View job


The only new commit since my last review is b71d78a, and it changes only ChatViewModelTest. The tests now use SourceView.PLAYER as the default source instead of EPISODE_DETAILS, and the two "chat shown" tests are merged into one. I found nothing new, and nothing from earlier reviews is still open.

@sztomek
sztomek force-pushed the feat/episode-chat-analytics branch from 02e2e93 to 5ca63e6 Compare October 12, 2026 15:58
@sztomek
sztomek force-pushed the feat/episode-chat-remove-episode-details-entry branch from b71d78a to 4800344 Compare October 12, 2026 15:58
@claude

claude Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @sztomek's task in 23s —— View job


The branch was rebased to 4800344. It now has four commits that make the same changes to the same seven files (+20/−369) as the version I reviewed last, including the ChatViewModelTest switch to SourceView.PLAYER. There are no new findings and none from earlier are still open.

@claude

claude Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @sztomek's task in 48s —— View job


The only new commit since my last review is 143d36f, the squashed #6122 (upgrade screen redesign). I found nothing in it that needs fixing, and nothing from earlier reviews is still open. The player now sends users without chat access to OnboardingUpgradeSource.EPISODE_CHAT instead of ChatPaywallFragment. Nothing still uses the code, strings or chat-module dependencies it removes (ChatPaywall*, chat_paywall_title/chat_preview_*, payment, settings). The PR description still says ChatPaywallFragment is kept, which is no longer true after this commit.

@dangermattic

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@sztomek
sztomek force-pushed the feat/episode-chat-remove-episode-details-entry branch from 143d36f to 876d86b Compare October 13, 2026 13:32
@sztomek
sztomek force-pushed the feat/episode-chat-analytics branch from 5ca63e6 to 56b4e9c Compare October 13, 2026 13:32
@claude

claude Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @sztomek's task in 31s —— View job


The branch was rebased onto the updated feat/episode-chat-analytics (56b4e9c) and now sits at 876d86b. It has the same five commits and the same 33 files (+212/−967) I reviewed last time, so there's nothing new to review and no earlier findings are still open. After the rebase, no code outside the translation files refers to ChatPaywall*, ChatBanner, IconChat, episodeChatAccess, openChat() or the removed chat_paywall_title/chat_preview_* strings.

@sztomek
sztomek force-pushed the feat/episode-chat-remove-episode-details-entry branch from 876d86b to b4c43c1 Compare October 13, 2026 14:50
@sztomek
sztomek force-pushed the feat/episode-chat-analytics branch from 56b4e9c to b7ddabf Compare October 13, 2026 14:50
@claude

claude Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @sztomek's task in 27s —— View job


The branch was rebased onto the updated feat/episode-chat-analytics (b7ddabf) and is now at b4c43c1. It has the same five commits and the same 33 files (+212/−967) as my last review, so there's nothing new to review and no earlier findings are still open. After the rebase, no code outside the translation files refers to ChatPaywall*, ChatBanner, IconChat, episodeChatAccess or the removed chat_paywall_title/chat_preview_* strings.

Base automatically changed from feat/episode-chat-analytics to feat/episode-chat-answer-rating October 14, 2026 10:59
@sztomek
sztomek force-pushed the feat/episode-chat-answer-rating branch from 0e73311 to 31c7a96 Compare October 14, 2026 11:49
@sztomek
sztomek force-pushed the feat/episode-chat-remove-episode-details-entry branch from b4c43c1 to 78e7be4 Compare October 14, 2026 11:50
@claude

claude Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @sztomek's task in 28s —— View job


This PR now targets feat/episode-chat-answer-rating and its head is 78e7be4. It has the same five commits and the same 33 files (+212/−967) as my last review, so there's nothing new to review and no earlier findings are still open. On the new base, no code outside the translation files refers to ChatPaywall*, ChatBanner, IconChat, episodeChatAccess, openChat() or the removed chat_paywall_title/chat_preview_* strings. The answer-rating test that came from the base also uses SourceView.PLAYER now.

Base automatically changed from feat/episode-chat-answer-rating to main October 14, 2026 11:59
@sztomek
sztomek force-pushed the feat/episode-chat-remove-episode-details-entry branch from 78e7be4 to 20971f3 Compare October 14, 2026 12:01
@claude

claude Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @sztomek's task in 24s —— View job


This push has nothing new to review and no open findings. #6142 has been merged, so the branch now sits on main (3ec5232) at 20971f3, with the same five commits and the same 33 files (+212/−967) I reviewed last time. On the new base, nothing in the chat module refers to ChatPaywall*, ChatBanner, IconChat, episodeChatAccess, the removed chat_paywall_title/chat_preview_* strings or SourceView.EPISODE_DETAILS.

@sztomek
sztomek merged commit fc3bb35 into main Oct 14, 2026
20 checks passed
@sztomek
sztomek deleted the feat/episode-chat-remove-episode-details-entry branch October 14, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants