Repository navigation
[Episode Chat] Remove the chat entry from Episode details - #6146
Conversation
|
Claude finished @sztomek's task in 28s —— View job I found nothing that should block this merge. I compared the diff against |
e3e8b43 to
c3a6d4b
Compare
6d9ce9e to
2105326
Compare
|
Claude finished @sztomek's task in 38s —— View job The branch was rebased to |
c3a6d4b to
11698c5
Compare
2105326 to
b82b438
Compare
|
Claude finished @sztomek's task in 39s —— View job This push has nothing new to review and no open findings. The branch is now three commits, at |
|
Version |
11698c5 to
02e2e93
Compare
b82b438 to
b71d78a
Compare
|
Claude finished @sztomek's task in 15s —— View job The only new commit since my last review is |
02e2e93 to
5ca63e6
Compare
b71d78a to
4800344
Compare
|
Claude finished @sztomek's task in 23s —— View job The branch was rebased to |
|
Claude finished @sztomek's task in 48s —— View job The only new commit since my last review is |
Generated by 🚫 Danger |
143d36f to
876d86b
Compare
5ca63e6 to
56b4e9c
Compare
|
Claude finished @sztomek's task in 31s —— View job The branch was rebased onto the updated |
876d86b to
b4c43c1
Compare
56b4e9c to
b7ddabf
Compare
|
Claude finished @sztomek's task in 27s —— View job The branch was rebased onto the updated |
0e73311 to
31c7a96
Compare
b4c43c1 to
78e7be4
Compare
|
Claude finished @sztomek's task in 28s —— View job This PR now targets |
78e7be4 to
20971f3
Compare
|
Claude finished @sztomek's task in 24s —— View job This push has nothing new to review and no open findings. #6142 has been merged, so the branch now sits on |
Description
Removes "Chat with Episode" from Episode details. The player's ⋯ menu (#6118) is now the only way into Ask about this episode, as in the P2 and Figma. This PR is based on #6141.
Removed
EpisodeFragment.openChat(),EpisodeFragmentViewModel.episodeChatAccess()and its tests. The view model and its test are now the same as onmain.ChatBannerandIconChat, which only Episode details used.Kept:
ChatPaywallFragmentandEpisodeChatAccess, which the player still uses. Also theepisode_chatstring and theic_aiicon, which the upgrade screen and transcripts use.The flag is off in production, so this changes nothing for users.
Fixes POC-954 https://linear.app/a8c/issue/POC-954
Testing Instructions
Use a debug build with "Episode Chat" on in Beta features.
Screenshots or Screencast
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...